Core Sync Improvement Enhancement

[GoogleCodeExporter]

Steps of enhancement development:
1. Introduce SyncMedium abstract class for handling majority of sync procedures
2. Implement and test SyncServer, which extends SyncMedium
3. Implement and test core functionality of SyncMedium
4. Implement and test SyncSMS
5. Create settings to handle the various sync methods

As development for the project continues, patches will be posted. The expected 
output is for syncing to work properly.

Additional notes will be posted as patches are submitted about progress.

Original issue reported on code.google.com by and.mats...@gmail.com on 14 Mar 2012 at 10:05

[GoogleCodeExporter]

I've completed steps 1-3 in the enhancement description above.

Just a few notes about what I've done:
    -The majority of syncing functionality has been split off into two new classes (SyncMedium, SyncServer) with another in progress (SyncSms)
        -Many of the methods from Communicator have been moved into SyncServer and refactored
    -Some Communicator methods were made public for use in SyncServer
    -A NullPointException was found in FindActivity that was fixed via null check

The previous sync code has been left within the repository for the time being. 
If there are ever any issues related to this patch, please let me know. In the 
mean time, the old sync process can be restored by removing the following lines:

"SyncServer syncServer = new SyncServer( mContext );
            syncServer.sync( authToken );
/*"

Found in OnPerformSync of SyncAdapter.

The WiFi syncing has been tested and all found issues have been fixed. Once 
again, if any issues were missed please let me know.

Original comment by and.mats...@gmail.com on 14 Mar 2012 at 10:17

Attachments:

• SyncImpPatch1.patch

[GoogleCodeExporter]

Testing patch.  It seems to work as intended for WiFi syncing.  Reviewing the 
code, it looks like it needs Javadoc comments (for all methods) and boilerplate 
comments, with license info, for all new files.  

Looking good!

Original comment by ram8...@gmail.com on 21 Mar 2012 at 12:39

• Changed state: Started

[GoogleCodeExporter]

The patch has been pushed.  A documentation (javadoc) update is needed at some 
point. 

Original comment by ram8...@gmail.com on 21 Mar 2012 at 12:46

[GoogleCodeExporter]

Original comment by ram8...@gmail.com on 21 Mar 2012 at 12:58

• Added labels: Difficulty-Intermediate

[GoogleCodeExporter]

New patch attached.

Changes include:
  -String -> Find conversion methods are now static and public
  -Many methods within SyncMedium are now public
  -Added additional methods for getting changed finds in various formats

In progress:
  -Majority of SyncSms has been completed
  -Testing SyncSms changes to confirm functionality

Next patch will include completed and tested SyncSms.
Additional commenting for new code will be added as methods are finalized.

Original comment by and.mats...@gmail.com on 22 Mar 2012 at 12:09

Attachments:

• SyncImpPatch2.patch

[GoogleCodeExporter]

New patch #3 added.

Changes include:
  -Added methods for getting list of available projects from Server
  -Added methods for setting current project
  -Cleaned up imports in SyncSms

In progress:
  -Adding java doc for all new functions added
  -Adding boilerplate copyright info for new files added
  -Testing SyncSms

This was a quick patch to help another area of development continue progress. 
The next patch will include the completed SyncSms and additional commenting.

Original comment by and.mats...@gmail.com on 27 Mar 2012 at 3:01

Attachments:

• SyncImpPatch3.patch

[GoogleCodeExporter]

Attached patch should be used instead of SyncImpPatch3.patch

It contains all the same changes as SyncImpPatch3.patch in addition to java 
docs for all new functions added and boilerplate copyright info for new files 
added

Original comment by and.mats...@gmail.com on 29 Mar 2012 at 2:48

Attachments:

• SyncImpPatch31.patch

[GoogleCodeExporter]

New patch #4 added.

Changes include:
  -Tested and completed SyncSms capabilities

Tested to make sure previous functionality still exists.

Note: There is still some work to do regarding cleaning up the no longer 
functional code. This will be investigated and discussed further before done.

Original comment by and.mats...@gmail.com on 4 Apr 2012 at 8:48

Attachments:

• SyncImpPatch4.patch

[GoogleCodeExporter]

Ok. Pushed all SyncImp patches.  In testing SendSMS, messages are sent properly 
and received by the phone.  But they don't seem to get handled by Posit. When a 
Find is received, shouldn't Posit open the AddFind and give the user the 
opportunity to save it?  

Original comment by ram8...@gmail.com on 5 Apr 2012 at 2:06

[GoogleCodeExporter]

Fixed SmsReciever to work with new plugin name.

Original comment by and.mats...@gmail.com on 5 Apr 2012 at 11:18

Attachments:

• SyncImpPatch41.patch

[GoogleCodeExporter]

Installed Patch41 by and pushed to the repository.

Original comment by ram8...@gmail.com on 10 Apr 2012 at 12:50

[GoogleCodeExporter]

New patch added.

Changes include:
  -Cleaned up deprecated code from Communicator
  -Completely removed SMSTransmitter.java from SMS plugin as it is completely replaced by SyncSMS
  -Cleaned up the transmitImage method in SyncServer

Tested creating new finds, syncing finds and syncing find via SMS. Previous 
functionality is still working as intended.

Original comment by and.mats...@gmail.com on 24 Apr 2012 at 9:21

Attachments:

• CleanUp.patch

[GoogleCodeExporter]

Andrew,

Nice job. I pushed your patch.  Before I mark this issue as resolved, I wanted 
to ask you whether you should just go ahead and remove the rest of the 
commented-out code in Communicator.  Since you've been working on that class, 
you're in a good position to decide.  If so, just go ahead and do that and 
submit another patch.

Thanks

Original comment by ram8...@gmail.com on 4 May 2012 at 3:23

[GoogleCodeExporter]

Second clean up patch added.

Changes include:
  -Cleaned the rest of the deprecated code from Communicator
  -Cleaned up various unused variables within the Communicator class as well

While taking a look at the commented out code it definitely appeared to be code 
that was used in older versions of POSIT. Many of the functions have been 
replaced with more recent code. I did a search throughout the project to make 
sure no references to these functions were commented out or used anywhere else. 
Nothing turned up so the removals shouldn't pose any problems.

I tested existing functionality on my phone just to double check.

Original comment by and.mats...@gmail.com on 4 May 2012 at 11:31

Attachments:

• CleanUp2.patch

[GoogleCodeExporter]

This issues is completed by Andrew's UCOSP project.

Original comment by ram8...@gmail.com on 5 May 2012 at 1:41

• Changed state: Fixed