google-code-export / pydicom

Automatically exported from code.google.com/p/pydicom
0 stars 0 forks source link

dataset.get() should return consistent results when called with a tag or with a string #134

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?

1. dataset.get("DicomString") returns a value
2. dataset.get(Tag(0xABCD,0x0000)) returns a DataElement, whose value is the 
same as the value above

I think the behavior should be made consistent, and either return a DataElement 
or a value in both cases.

Original issue reported on code.google.com by francesc...@gmail.com on 16 Sep 2013 at 10:14

GoogleCodeExporter commented 9 years ago
It's an interesting thought ... but the current behaviour is in line with what 
happens if you do:
dataset.DicomString  vs. dataset[Tag(...)]. I don't remember whether get() was 
deliberately modelled after that or whether it just fell out of the coding that 
way. Will keep the issue alive and think about this.

Thanks
Darcy

Original comment by darcymason@gmail.com on 18 Sep 2013 at 3:56