google-code-export / pydicom

Automatically exported from code.google.com/p/pydicom
0 stars 0 forks source link

No force parameter in contrib.pydicom_series.read_files #146

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The problem is simple enough. On the last version of pydicom, 0.9.8, there's no 
way to use the "force" parameter in read_files. It seems like a bug to me 
because you can use it with read_file.

d = dicom.read_file('~/path/im.dcm', force=True)  # Works
series = read_files('~/path', force=True)  # No "force" parameter

I believe this change won't break anything for other users if we default force 
to False.

I already cloned the repo on my computer and done the required change. I just 
need to understand how code.google.com works to submit a patch :) I'll update 
this issue with a clone soon.

Original issue reported on code.google.com by nilgoye...@gmail.com on 9 May 2014 at 1:15

GoogleCodeExporter commented 9 years ago
I cloned and pushed a fix there
https://code.google.com/r/nilgoyette-pydicom-force/

The fix is really simple, I just add the parameter to read_files and pass it to 
read_file.

Original comment by nilgoye...@gmail.com on 9 May 2014 at 1:52

GoogleCodeExporter commented 9 years ago
Closed by revision 591e350da859

Original comment by darcymason@gmail.com on 12 May 2014 at 10:13