google-code-export / pyglet

Automatically exported from code.google.com/p/pyglet
BSD 3-Clause "New" or "Revised" License
1 stars 1 forks source link

image.DDS_RGB_DXT1_LOAD (and similar) throw ImageException #580

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.Run python test/test.py image-dds
2.Try to run any of these tests.

What is the expected output? What do you see instead?
The test should not throw a exception.

Fix:
The problem is that the image.codecs.s3tc.PackedImageData doesn't override the 
method get_texture inherited from AbstractImage.
Reusing the implementation of _get_texture to implement get_texture fix the 
problem. 
(There is another bug, a function in the same module uses the unknow object 
'c_ubyte', this can be solved too using 'ctypes.c_ubyte')

The diff with both fixs are attached.

Original issue reported on code.google.com by petete.z...@gmail.com on 19 Jun 2012 at 4:44

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for your patch. I've imported it and it eliminates test errors for the 
image section on Mac OS X, 32-bit.

Original comment by winstonw...@gmail.com on 22 Jun 2012 at 9:25

GoogleCodeExporter commented 9 years ago

Original comment by winstonw...@gmail.com on 22 Jun 2012 at 9:26