search

google-code-export / pysal

Automatically exported from code.google.com/p/pysal
Other
1 stars 1 forks source link

check __all__ in spatial_dynamics.markov #132

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I will write the unit test for this module, but I just want to make sure that 
I'm focusing on the right components. Currently, 
__all__=["Markov","LISA_Markov","Spatial_Markov"], but there's a number of 
other helper functions. Should the unit test include all the helper functions 
or just the classes in the all? If this is the case should the helper functions 
be included in the all?

Original issue reported on code.google.com by nmali...@gmail.com on 13 Jan 2011 at 9:31

GoogleCodeExporter commented 9 years ago 
Helper functions should NOT be included in __all__, but should still be tested. 
 Only include functions/classes in all that should be exposed to the public 
API. In otherwords if a user will ever need it, it should be in all.

The testing scripts only checks __all__, but this should be considered a bug 
not a feature. We should write some regular expressions to grab All functions, 
classes and even methods.

Original comment by schmi...@gmail.com on 13 Jan 2011 at 9:48

GoogleCodeExporter commented 9 years ago

Original comment by sjsrey on 18 Jan 2011 at 3:26