search

google-code-export / q4e

Automatically exported from code.google.com/p/q4e
0 stars 1 forks source link

[View] Profile View. #5

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Create a Profile View.
  Show available profiles.
  Highlight Active profiles.

Original issue reported on code.google.com by joakim.erdfelt on 17 Jul 2007 at 7:53

GoogleCodeExporter commented 9 years ago

Original comment by xgenesis...@gmail.com on 23 Jul 2007 at 8:35

GoogleCodeExporter commented 9 years ago 
Even when this issue has not received much attention in the q4e lists, it has 
been
commented in some others, like maven's: http://tinyurl.com/28zac5

I think this would be a good issue for new contributors.

Original comment by amu...@gmail.com on 9 Mar 2008 at 5:22

GoogleCodeExporter commented 9 years ago 
Hi,

Thanks for pointing out that this would be a good issue for us to ponder. 
Here's what
I've developed so far. Hope this helps.

Original comment by ramire...@gmail.com on 15 Mar 2008 at 3:39

Attachments:

GoogleCodeExporter commented 9 years ago 
It is a nice view to display available profiles. It is a good start but it 
needs some
polishing:
- Clean-up commented code
- Should only apply to q4e-enabled projects. You can use
MavenNatureHelper.getInstance().hasQ4ENature() for that.
- Should re-use the cached project model if possible (through
MavenManager.getMavenProjectManager()) instead of re-parsing the pom each time.
- Use of IAdaptable could be more general (see
http://dev.eclipse.org/blogs/wayne/2007/11/05/adapting/)
- Some javadoc is always a plus.

Could you please update the patch and submit it again? Once we have the basic
functionality in place, we can start adding support for enabling/disabling 
profiles
and other features as separate issues.

Original comment by amu...@gmail.com on 15 Mar 2008 at 7:00

GoogleCodeExporter commented 9 years ago 
What are the basic functionality? Is it showing pom profile, user settings.xml
profile, global settings.xml profile, and project descriptor(profile.xml) 
profile and
highlighting the active profiles only? Would that do for now and just add more 
after
the code has been polished?

Btw, I used IAdaptable because I tried using object instanceof IProject but 
then,
when you click on the project, it always returns false.

Original comment by ramire...@gmail.com on 15 Mar 2008 at 11:51

GoogleCodeExporter commented 9 years ago 
Hi Abel,

I updated the patch today and applied the polishing guidelines you said.

The patch still keeps on re-parsing the settings.xml each time the user has new
selection.

I was thinking to add a Job/Thread that monitors if settings.xml changed. If 
yes then
we'll re-parse the settings.xml.

Assuming that global settings.xml and user settings.xml is specified in maven
preference page then 2 Jobs will be added here. One job that will monitor for 
global
settings.xml and another for user settings.xml.

Do you think adding a job is a good idea? Or re-parsing settings.xml would 
already do...

Original comment by ramire...@gmail.com on 17 Mar 2008 at 9:19

GoogleCodeExporter commented 9 years ago 
Oh... I forgot to attach the patch. :D 

Here it is.

Original comment by ramire...@gmail.com on 17 Mar 2008 at 9:20

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by amu...@gmail.com on 24 Mar 2008 at 7:35

GoogleCodeExporter commented 9 years ago 
I don't like the implementation of addProfileToTable method so i improved it a 
bit.

Original comment by ramire...@gmail.com on 25 Mar 2008 at 3:47

Attachments:

GoogleCodeExporter commented 9 years ago 
Committed the latest patch in r1317 with minor changes:

 - Simplify the search for IProject, since IFolder, IFile and IProject are all
IResources.
 - Completed support for IAdaptable lookup by calling
Platform.getAdapterManager().loadAdapter() if everything else fails.

Original comment by amu...@gmail.com on 29 Mar 2008 at 6:52