search

google-code-export / rainmeter

Automatically exported from code.google.com/p/rainmeter
1 stars 0 forks source link

Dragging skins to new locations is now broken... #111

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
There is a new bug (Not sure which revision caused it, but I think it
started sometime on or after 229) where when you move a skin by dragging,
and for any reason the skin is refreshed / redrawn, either by a refresh
from the context menu or by a measure or !bang causing a redraw
automatically, the skin jumps back to the original position.

It seems to be that the write to WindowX and WindowY in Rainmeter.ini is
one "refresh/redraw cycle" behind.  If you move a skin, then move it again
before the refresh/redraw, it will jump back to the location of the first
"move".

I can sit with Rainmeter.ini open in a text editor and see that the WindowX
and WindowY is not being updated properly when a skin is moved.

We must not make a public beta build until this is located and fixed.

Original issue reported on code.google.com by jsmor...@gmail.com on 26 Sep 2009 at 3:53

GoogleCodeExporter commented 9 years ago

Original comment by jsmor...@gmail.com on 26 Sep 2009 at 3:54

GoogleCodeExporter commented 9 years ago

Original comment by jsmor...@gmail.com on 26 Sep 2009 at 3:54

GoogleCodeExporter commented 9 years ago 
I believe the issue MIGHT be in r229 in MeterWindow.cpp at line 3283 where
"m_Dragging = false;" was added.

Spx, could you look at this and see what you think?

Original comment by jsmor...@gmail.com on 26 Sep 2009 at 4:10

GoogleCodeExporter commented 9 years ago 
Removing this "m_Dragging = false;" line SEEMS to fix the issue, but I will 
leave it
to you to see if I am correct and make whatever changes you think correct spx...

Original comment by jsmor...@gmail.com on 26 Sep 2009 at 4:11

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
I can verify that this is not an issue in build r223
In the following environs:
Vista 32bit
Vista 64bit
7 RC1 64bit

Original comment by evmckay on 26 Sep 2009 at 4:47

GoogleCodeExporter commented 9 years ago 
[deleted comment]
GoogleCodeExporter commented 9 years ago 
Sorry... Thank you for the verification. I understood, and removed it on r233.

Original comment by spx268 on 26 Sep 2009 at 4:56

GoogleCodeExporter commented 9 years ago 
No apologies necessary friend :)

Great work!

Original comment by evmckay on 26 Sep 2009 at 5:11

GoogleCodeExporter commented 9 years ago

Original comment by jsmor...@gmail.com on 26 Sep 2009 at 5:13

GoogleCodeExporter commented 9 years ago 
How can i fix it in ver 1.1?

Original comment by fathea...@gmail.com on 2 Jan 2010 at 8:52