Array.toString always being called regardless of Logging level in BaseRTMPTConnection.PendingData logs writes. This is a performance issue.

[GoogleCodeExporter]

What steps will reproduce the problem?
1.  have a look at the code.

ie. log.trace("Buffer: {}", Arrays.toString(ArrayUtils.subarray(byteBuffer, 0, 
32)));

What is the expected output? What do you see instead?
the Arrays.toString if needed should be conditional.  Is it needed ?

What version of the product are you using? On what operating system?  4616.

Please provide any additional information below.

Original issue reported on code.google.com by missingm...@gmail.com on 13 Apr 2013 at 12:43

[GoogleCodeExporter]

Original comment by mondain on 17 Apr 2013 at 2:20

• Changed state: Started

[GoogleCodeExporter]

This issue was closed by revision r4615.

Original comment by mondain on 17 Apr 2013 at 2:42

• Changed state: Fixed

[GoogleCodeExporter]

Would love to see a Windows snapshot of r4615. Would it be possible?

Original comment by neverbi...@gmail.com on 17 Apr 2013 at 3:13

[GoogleCodeExporter]

I'll update the snapshots this afternoon and i'll send an email to the list.

Original comment by mondain on 17 Apr 2013 at 4:19