Bogus warnings about failing file system persistence (includes suggested fix)

[GoogleCodeExporter]

Whenever red5 after r4587 calls save(IPersistable object), a bogus warning for 
failed write is produced, since the method AlLWAYS returns false.

The respective code remains unchanged up to latest revision.

code (line 563 ff) of the refactoring:

        /** {@inheritDoc} */
        @Override
        public boolean save(IPersistable object) {
                if (super.save(object)) {
                        queue.add(object);
                }
                return false;
        }

should be probably:

        /** {@inheritDoc} */
        @Override
        public boolean save(IPersistable object) {
                if (super.save(object)) {
                        queue.add(object);
                    return true;
                } else {
                return false;
                }
        }

Original issue reported on code.google.com by S.No...@gmail.com on 5 May 2013 at 2:44

[GoogleCodeExporter]

Original comment by mondain on 6 May 2013 at 12:34

• Changed state: Started

[GoogleCodeExporter]

This issue was closed by revision r4639.

Original comment by mondain on 6 May 2013 at 12:36

• Changed state: Fixed