search

google-code-export / rietveld

Automatically exported from code.google.com/p/rietveld
Apache License 2.0
1 stars 0 forks source link

Request for "View All" to see side-by-side diffs for the entire patch at once #114

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Request for "View All" to see side-by-side diffs for the entire patch at 
once

For many code reviews, I just click the "Download raw patch set" link 
initially so that I can get a feel for the entire patch and more quickly 
digest the changes.  (Browsing a patch one file at a time can be painfully 
slow.)  Then, I typically go back over the patch one file at a time to make 
my comments.  It would save me a lot of time if I could have a view of the 
entire patch where I could also make my comments.

An alternative solution is to make Reitveld prefetch the next side-by-side 
diff so that 'j/k' become instantaneous.  This is still suboptimal because 
ideally one should be able to quickly glance between the patch for file 3 
and file 7 by just scrolling their browser view or moving their eyes up and 
down a screen ;-)

Original issue reported on code.google.com by darin@chromium.org on 11 May 2009 at 5:33

GoogleCodeExporter commented 9 years ago 
The problem with trying to do view all in one page is that the html required 
for each 
file is quite large (there's a big block for every line).  Even today, you can 
make a 
diff for one file that doesn't display because the generated html is larger 
than 1MB 
(App Engine's limit).  I'll try to profile what's taking time when going to the 
next/previous file.

Original comment by john.abd...@gmail.com on 11 May 2009 at 5:58

GoogleCodeExporter commented 9 years ago 
Maybe the next/previous page could just be pre-fetched then?

Original comment by darin@chromium.org on 11 May 2009 at 6:25

GoogleCodeExporter commented 9 years ago 
Really, it just needs to be faster to load in general.  If only I had infinite 
time to 
work on this sort of thing.

Darin, I normally middle-click the "view" link for all files when opening a 
review to 
side-step the latency.

Original comment by evan@chromium.org on 11 May 2009 at 8:44

GoogleCodeExporter commented 9 years ago 
Yeah... that helps.  I guess the unified diff is still attractive since I can 
quickly 
scroll through the various files.

Original comment by darin@chromium.org on 11 May 2009 at 8:54

GoogleCodeExporter commented 9 years ago

Original comment by albrecht.andi on 6 Apr 2012 at 7:25