google-code-export / rtgui

Automatically exported from code.google.com/p/rtgui
1 stars 0 forks source link

Notice: Undefined index: query in control.php on line 123 #99

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
This is not a feature/support request forum - use
http://groups.google.com/group/rtgui for discussion or help of rtGui.
Please ONLY report bugs here.

What steps will reproduce the problem?
1. Open up rtGui's main page
2. Click X to delete a torrent (so the URL of the command is like that:
https://path/to/rtgui/control.php?hash=xxxxx&cmd=delete)

What is the expected output? What do you see instead?

The expected output would be to return to the main page and the selected
torrent to be removed.

Instead of that I get a blank page with the following message: "Notice:
Undefined index: query in control.php on line 123".

However, when I manually return to the main page, the torrent is indeed
deleted.

What version of the product are you using? On what operating system?

I am using rTorrent 0.8.5/0.12.5 with rtGui v0.2.7 on Linux x86.
Apache 2.2.11 with mod_scgi 1.12 and PHP 5.2.10. 

Please provide any additional information below.

rTorrent was built against xmlrpc-c 1.18.02.

Original issue reported on code.google.com by ioannis....@gmail.com on 14 Sep 2009 at 5:01

GoogleCodeExporter commented 9 years ago
This could be due to newer version of rTorrent.

If possible, can you try version 0.8.4/0.12.4 ?

I will install newer version, and adapt rtGui if necessary in near future.  (I 
just 
need a spare evening!)

-Simon

Original comment by lemonbe...@gmail.com on 14 Sep 2009 at 6:28

GoogleCodeExporter commented 9 years ago
You might be right, I have downgraded to 0.8.4/0.12.4, deleted a couple of 
torrents
and I did not get any notice.

Despite that please do consider adapting rtGui to the newest version of 
rTorrent.

Thanks!

John

Original comment by ioannis....@gmail.com on 15 Sep 2009 at 9:18

GoogleCodeExporter commented 9 years ago
I just got the same notice once again, even though I was using 0.8.4/0.12.4

Is there any way to track this down?

Original comment by ioannis....@gmail.com on 18 Sep 2009 at 3:54

GoogleCodeExporter commented 9 years ago
This may or may not be related, but I used to get undefined index not just in 
this
cased. I tracked it down to the fact that XML-RPC was returning NULLs, but the 
code
doesn't check for empty responses, it checks for faults in XML-RPC (via 
is_xml_fault).

My workaround for this was a do..while loop around the do_xmlrpc calls in 
functions.php.

so change:
$response = do_xmlrpc($request);

to:
do {
  $response = do_xmlrpc($request);
while (!is_array($response));

There is probably a more elegant way of doing this, but I could use my spare 
evenings
otherwise :)

Original comment by shez...@gmail.com on 19 Sep 2009 at 9:52

GoogleCodeExporter commented 9 years ago
I've tested rtGui on rTorrent 0.8.5/0.12.5 and can't find any problems.

Is your server bery 'busy' doing other things, to the extent it's being 
thrashed?  
I'm wondering if something is timing out somewhere..

Original comment by lemonbe...@gmail.com on 24 Sep 2009 at 6:38

GoogleCodeExporter commented 9 years ago
well i run a low power intel atom box.. not much horsepower there, so it's very
possible that there may be trashing. as to why i get empty response strings via 
xml
rpc, i dunno. its unlikely that rtorrent itself is at fault.

note that i run linux x86, lighttpd + php fastcgi and xml rpc through a local 
unix
socket. everything's up to date.

Original comment by shez...@gmail.com on 26 Sep 2009 at 3:10