cas_auth.guess_url() can be a bit better

[GoogleCodeExporter]

Since the client is fairly rails specific, why not use this to figure out
the url instead? 

service = controller.url_for(controller.params())

instead of parsing and joining the controller parameters? 

BTW, thanks for the client works like a charm. 

Original issue reported on code.google.com by delag...@gmail.com on 8 Aug 2007 at 2:04

[GoogleCodeExporter]

Alright, I'll take a look. I didn't write that part of the code and the original
author is no longer involved, so I'll have to see if there are some indirect 
reasons
why he chose not to do that. Also, in the next few weeks I will likely have to 
make
RubyCAS-Client Camping-compatible, which may significantly change the way the 
library
is organized (i.e. probably some more abstraction, with two different 
compatibility
wrappers, one for Rails the other for Camping).

Original comment by matt.zuk...@gmail.com on 8 Aug 2007 at 2:44

• Changed state: Accepted

[GoogleCodeExporter]

Right thanks a bunch! I was actually thinking of porting the client to a merb 
plugin
for creating a small merb portal to my set of rails apps (and also to auth file
uploads via merb). There are a couple of controller methods that are not in 
sync with
the way rails does this and obviously my proposed solution would not work for 
merb. 

Don't know anything about camping.

I'll drop a line on this thread when I have something to show. 

Original comment by delag...@gmail.com on 8 Aug 2007 at 2:57

[GoogleCodeExporter]

It looks like Merb borrowed some code from Camping, so it might be possible to 
make
the Camping version of the client compatible with Merb. I'll keep this in mind 
when I
do the refactoring.

Original comment by matt.zuk...@gmail.com on 8 Aug 2007 at 3:13

[GoogleCodeExporter]

Original comment by matt.zuk...@gmail.com on 8 Aug 2007 at 7:41

• Added labels: Type-Enhancement
• Removed labels: Type-Defect

[GoogleCodeExporter]

Just as an update, I'm looking at doing a major refactoring of the client in 
the next
week or so. All of the CAS protocol functionality will be abstracted out, 
making it
much easier to use in a non-Rails context (i.e. there will be a CAS client 
library,
and then simpler wrappers for individual frameworks: Rails, Camping, etc.)

Original comment by matt.zuk...@gmail.com on 24 Aug 2007 at 6:15

[GoogleCodeExporter]

P.S. I've incorporated your suggestion into the CAS client... it will likely get
released in a final 1.x release before I start working on 2.x.

Original comment by matt.zuk...@gmail.com on 24 Aug 2007 at 6:22

• Changed state: Fixed
• Added labels: 1.1.0

[GoogleCodeExporter]

Matt, this new architecture sounds great. It will certainly open up the client 
to
other frameworks.

Could we implement a similar architecture for the rubycas-server?

Original comment by ruby...@gmail.com on 29 Aug 2007 at 1:22