google-code-export / s3ql

Automatically exported from code.google.com/p/s3ql
0 stars 0 forks source link

Problem mounting: LegacyDecryptDecompressFilter object has no attribute decrypt #444

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
It looks like revision 8a882d9405c1 in version 2.6 introduced an issue in 
LegacyDecryptDecompressFilter. When I try to mount one of my old buckets, an 
exception is thrown:

    AttributeError: 'LegacyDecryptDecompressFilter' object has no attribute 'decrypt'

The call to `self.decrypt` in its read() method should actually be to 
`self._decrypt`.

Looking at a coverage report for s3ql.backends.common, the test suite has no 
coverage for LegacyDecryptDecompressFilter or the backward compatibility code 
in convert_legacy_metadata. I'm not sure what the right way to add 
backward-compatibility tests is, but I can see issues like this happening as 
long as the tests can't catch them.

Original issue reported on code.google.com by macdonellba on 10 Dec 2013 at 3:25

GoogleCodeExporter commented 9 years ago
Thanks for the report! I don't think I'll be creating test cases for this, as 
the need for the legacy decompress code should just go away over time.

Original comment by Nikolaus@rath.org on 11 Dec 2013 at 2:01

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 5d68ecd852e4.

Original comment by Nikolaus@rath.org on 11 Dec 2013 at 2:04