google-code-export / saplink

Automatically exported from code.google.com/p/saplink
1 stars 2 forks source link

Missing class exception definition #77

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
Class ZSAPLINK_NUGGET is missing the exception class ZCX_SAPLINK in the 
parameters section of 
its contrsuctor.

This produces a compiler warning and may result in a short dump.

This is then not handled in the object instantiation within program ZSAPLINK

Ed

Original issue reported on code.google.com by edwardme...@gmail.com on 2 Oct 2007 at 2:19

GoogleCodeExporter commented 9 years ago
I check what Ed said, in release:
basis 7.0 SP 12
Saplink 0.1.3

I agree with him that there is a problem in the source, but I don't see in 
which 
case it could occur in saplink 0.1.3 : ZSAPLINK program always checks that the 
file 
name is entered, thus the RAISE EXCEPTION TYPE zcx_saplink cannot happen.

So, this issue should be qualified as "minor enhancement".

But of course, for the state-of-the-art, and for maintenance/enhancements, we 
should 
define the exception at method level.

I tested with this little program to check whether SAP sends a warning or an 
error 
at compile time.

REPORT ZXXX.

CLASS ZZZZZ DEFINITION.
  PUBLIC SECTION.
    METHODS CONSTRUCTOR.
ENDCLASS.

CLASS ZZZZZ IMPLEMENTATION.
  METHOD CONSTRUCTOR.
    DATA X TYPE REF TO ZSAPLINK_NUGGET.
    CREATE OBJECT X.
  ENDMETHOD.
ENDCLASS.

START-OF-SELECTION.
DATA Y TYPE REF TO ZZZZZ.
CREATE OBJECT Y.

When we compile ZXXX, there is no warning at all that CREATE OBJECT X can 
produce 
exception ZCX_SAPLINK.
When we run it, we get a dump UNCAUGHT_EXCEPTION.

If we now define the exception ZCX_SAPLINK in the CONSTRUCTOR of 
ZSAPLINK_NUGGET, 
when we compile ZXXX, we get a warning that we should catch this exception 
(it's 
only a warning, but this info is unvaluable ;-)) (detailed message is: The 
exception 
ZCX_SAPLINK is neither caught nor is it declared in the RAISING clause 
of "CONSTRUCTOR".)

Original comment by sandra.r...@gmail.com on 18 Nov 2007 at 10:08

GoogleCodeExporter commented 9 years ago

Original comment by mepmarc...@gmail.com on 19 Aug 2008 at 2:44