'make check' fails and segfaults when build directory differs from source directory

[GoogleCodeExporter]

'make check' will fail tests and segfault when running configure in another 
directory (not the source directory).

Steps to reproduce:

1. Unpack the serf-1.2.1 tarball
2. mkdir BUILD && (cd BUILD && ../configure && make && make check)

Expected result:

Running ./configure && make && make check in a freshly-unpacked serf-1.2.1 
directory yields:

== Running test_all ==
............................

OK (28 tests)

Actual result:

== Running test_all ==
1079170496:error:1408A0C1:SSL routines:SSL3_GET_CLIENT_HELLO:no shared 
cipher:s3_srvr.c:1353:
........FFF.................

There were 3 failures:
1) test_serf_ssl_handshake: ../test/test_context.c:93: expected <0> but was 
<20014>
2) test_serf_ssl_trust_rootca: ../test/test_context.c:1190: expected <0> but 
was <98>
3) test_serf_ssl_application_rejects_cert: ../test/test_context.c:1230: 
expected <0> but was <98>

!!!FAILURES!!!
Runs: 28 Passes: 25 Fails: 3

And then the test runner segfaults.

Using serf 1.2.1 on Ubuntu 13.04, x86.

Original issue reported on code.google.com by danilopi...@gmail.com on 8 Jul 2013 at 12:55

[GoogleCodeExporter]

I can reproduce this issue by following the described steps.

The issue is that the tests will look for test certificates in the ./test and 
./test/server folders. When you build outside the source directory those files 
aren't copied to your build directory.

The tests succeed after:
cd BUILD
cp ../test/*.pem ./test
cp ../test/server/*.pem ./test/server

No idea if we want to fix this, given that the next release will use scons as 
only build system.

Unfortunately, the scons equivalent doesn't work either:

serftrunk lgo$ mkdir bin
serftrunk lgo$ cd bin

bin lgo$ scons -Y .. check
scons: Reading SConscript files ...
scons: done reading SConscript files.
scons: Building targets ...
build/check.sh
sh: build/check.sh: No such file or directory
scons: *** [check] Error 127
scons: building terminated because of errors.

So I propose we fix this in scons for serf 1.3.x.

thanks for the report!

Lieven

Original comment by lieven.govaerts@gmail.com on 8 Jul 2013 at 1:29

• Changed state: Accepted
• Added labels: Component-Scripts

[GoogleCodeExporter]

Attached a patch for 1.2.x. It might just be useful to someone (users, 
packagers, etc.).

Original comment by danilopi...@gmail.com on 11 Jul 2013 at 5:25

Attachments:

• pem_certificates_builddir_1.2.x.diff

[GoogleCodeExporter]

Any update on whether this will be addressed for the SCons build system?

Original comment by vega.james@gmail.com on 28 Dec 2013 at 2:35

[GoogleCodeExporter]

Yay! This issue was fixed by Justin in r2324. The fix will be included in serf 
1.4.0 (later this summer).

Original comment by lieven.govaerts@gmail.com on 28 Jun 2014 at 9:37

• Changed state: Fixed