search

google-code-export / serf

Automatically exported from code.google.com/p/serf
Apache License 2.0
1 stars 1 forks source link

Setting RPATHon Solaris broken in SConstruct #115

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Building serf 1.3 on Soalris 10 using custom path for APR, APU and OPENSSL 
results in a shared lib with the RPATH set to the concatenated lib dirs of APR, 
APU and OPENSSL, without the necessary ":" separator between those paths.

Example:

/opt/local/serf-1.3.0/lib/opt/local/apr-1.4.8/lib/opt/local/lib/opt/local/apr-ut
il-1.5.2/lib/opt/local/lib

Correct would have been:

/opt/local/serf-1.3.0/lib:/opt/local/apr-1.4.8/lib:/opt/local/lib:/opt/local/apr
-util-1.5.2/lib:/opt/local/lib

The wrong snippet in SConstruct is:

   342  # On Solaris, the -R values that APR describes never make it into actual
   343  # RPATH flags. We'll manually map all directories in LIBPATH into new
   344  # flags to set RPATH values.
   345  if sys.platform == 'sunos5':
   346    for d in env['LIBPATH']:
   347      env.Append(RPATH=d)

It simply appends each path and forgets to insert the colon separator.

Regards,

Rainer

Original issue reported on code.google.com by rainer.j...@kippdata.de on 28 Jul 2013 at 11:56

GoogleCodeExporter commented 9 years ago 
Fixed in r2081, we will include it in serf 1.3.1.
thanks for the report.

Lieven

Original comment by lieven.govaerts@gmail.com on 29 Jul 2013 at 12:02