google-code-export / serf

Automatically exported from code.google.com/p/serf
Apache License 2.0
1 stars 1 forks source link

protect buckets/mmap_buckets.c from compilation if APR_HAS_MMAP == 0 #97

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. compile serf with an APR version without MMAP support.

What is the expected output? What do you see instead?
compilation should not break, but it does break.

What version of the product are you using? On what operating system?
SVN-HEAD; NetWare.

Please provide any additional information below.
Patch to fix this issue:

Index: buckets/mmap_buckets.c
===================================================================
--- buckets/mmap_buckets.c      (revision 1825)
+++ buckets/mmap_buckets.c      (working copy)
@@ -16,6 +16,8 @@
 #include <apr_pools.h>
 #include <apr_mmap.h>

+#if APR_HAS_MMAP
+
 #include "serf.h"
 #include "serf_bucket_util.h"

@@ -116,3 +118,6 @@
     serf_mmap_peek,
     serf_default_destroy_and_data,
 };
+
+#endif /* APR_HAS_MMAP */
+

Original issue reported on code.google.com by 0x1...@googlemail.com on 6 May 2013 at 2:19

GoogleCodeExporter commented 9 years ago
Fixed on trunk in r1877.
Thanks for the report!

Original comment by lieven.govaerts@gmail.com on 28 May 2013 at 9:10