google-code-export / slim3

Automatically exported from code.google.com/p/slim3
1 stars 1 forks source link

support for AysncDatastoreService coming with 1.4.0 SDK #57

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
it would be very nice if slim3 supported the low-level AysncDatastoreService 
that's in the 1.4.0 SDK.

this will allow multiple requests to the datastore service to execute in 
parallel while still being able to use slim3 (which i really like)

Original issue reported on code.google.com by l...@eatstuf.com on 22 Nov 2010 at 3:41

GoogleCodeExporter commented 9 years ago

Original comment by higaya...@gmail.com on 22 Nov 2010 at 4:30

GoogleCodeExporter commented 9 years ago
Slim3 Datastore rocks!
Please add async support

Original comment by gal.dol...@gmail.com on 30 Nov 2010 at 4:04

GoogleCodeExporter commented 9 years ago
i created async versions of Datastore, DatastoreDelegate and a couple other 
necessary classes.  it really just supports async get, put and delete methods.  
i piped the future objects through from AsyncDatastoreService to the return of 
the corresponding AsyncDatastore methods.

i ported over the necessary tests as well, but i did not add any tests to 
explicitly test for asynchronous behavior, instead i forced each call to block 
by calling ".get()" on any Future objects returned by the datastore.  this 
ensures that the tests will always reproduce exactly, and that they perform the 
same test as their non-async counterparts. 

global transactions are not supported by these files and queries are blocking 
as well.

some methods in DatastoreDelegate process the results of a Datastore RPC, i 
created a FutureChain abstract class that allows this processing to occur 
without blocking on the RPC in the AsyncDatastoreDelegate version.  

please take a look and diff these against the non-async versions.  i started 
with whatever was in SVN yesterday, should be fairly up to date.

if you do take a look, please search for any "FIXME" or "TODO" tags.  there 
were a couple cases where i was not sure exactly what to do, it would be good 
for an expert to review those.

hopefully this will be helpful one way or another :) 

Original comment by l...@eatstuf.com on 6 Dec 2010 at 1:54

Attachments:

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Thanks a lot. I will include your patches in the latest slim3's source as soon 
as possible.

Original comment by higaya...@gmail.com on 6 Dec 2010 at 3:38

GoogleCodeExporter commented 9 years ago

Original comment by higaya...@gmail.com on 22 Dec 2010 at 1:04