google-code-export / student-worker-relational-database

Automatically exported from code.google.com/p/student-worker-relational-database
1 stars 1 forks source link

Some permissions are hard coded based on group name #279

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
This makes changing permission group names impossible. Faculty shouldn't even 
be a group. is_staff implies it but we still need some way to make staff have 
access to a few perms. 

Evil string of commands to find hardcoded groups:
find -name '*.py' | xargs grep -Fi '.groups.' | sed 's/)/)\n/g' | grep 'name=' 
| sed "s/^.*name=['\"]\(.*\)['\"].*$/\1/" | sort | uniq

Currently, these are:
company
cwsp
faculty
registrar
students
teacher
viewer

From the master:

3:58 PM 
David: faculty comes from me thinking it meant anyone who works at a school
3:59 PM 
so anyone who isn't a student nor supervisor

it might be hard coded

Original issue reported on code.google.com by dmbs...@gmail.com on 10 Feb 2012 at 1:51

GoogleCodeExporter commented 9 years ago
I removed the most obvious cases. We still use students, faculty, and company 
to determine some things. Ideally though it should be possible to create groups 
like registrar by another name.

Exception is import, which is going to be redone anyway.

Original comment by dmbs...@gmail.com on 17 Feb 2012 at 7:36

GoogleCodeExporter commented 9 years ago
This issue was closed by revision 1f97a46991cb.

Original comment by da...@burkesoftware.com on 17 Feb 2012 at 7:36