google-code-export / substruct

Automatically exported from code.google.com/p/substruct
1 stars 0 forks source link

last item can be bought by more than one person as long as they both have it in their cart before one of them confirms order #112

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. When there is 1 item of a product left it will allow 2 people to buy it
if person1 places it into their cart before person2 confirms their order in
the last step of check out.

What is the expected output? What do you see instead?
I would think the completion of the sale of an item would hinge upon it's
availability at the time of order confirmation, not just upon its
availability when adding to the cart.

I see negative numbers in my inventory!

What version of the product are you using? On what operating system?
substruct_rel_1-0-a3 on Apache 2.2.8 on Linux

Original issue reported on code.google.com by xmischi...@gmail.com on 26 Jul 2008 at 5:05

GoogleCodeExporter commented 9 years ago
Here goes a patch, it cannot be tested with tests so Im making something that in
theory seems right and doesn't break anything. Theres a high possibility that it
cannot be applied clean as my working copy has some other patches.

The test coverage was run again and at least it doesn't break and recover the 
stock
quantity on errors.

Follows a text file with something to illustrate what I think a worst case 
scenario.

It uncover another problem with the administrative interface, when the order 
status
is changed manually, probably it makes the stock be out of sync.

Regards.

Original comment by edmundo...@gmail.com on 30 Jul 2008 at 4:58

Attachments:

GoogleCodeExporter commented 9 years ago
I'm sleeping on this issue until I take a good look at the discussion here:

http://groups.google.com/group/substruct/browse_thread/thread/c641b5bed312f489/8
3324428408f29f4

Original comment by subim...@gmail.com on 11 Aug 2008 at 11:42

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago

Original comment by subim...@gmail.com on 16 Aug 2008 at 3:49

GoogleCodeExporter commented 9 years ago
Also [sorry can't find the issue] need to make sure that if users add more to 
their
inventory after "aborting" a checkout that they get charged tax and shipping is
recalculated for their order.

Original comment by rogerpack2005 on 30 Oct 2008 at 2:29