search

google-code-export / tovid

Automatically exported from code.google.com/p/tovid
1 stars 0 forks source link

ffmpeg aspect parameter selection in todisc does not work #165

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In r3497, todisc line 3786 
(https://code.google.com/p/tovid/source/browse/trunk/tovid/src/todisc#3786) 
there is this check and it's not working:
if grep -qw ^setdar <<< "$ff_filters"; then

The problem seems to be that 'setdar' does not appear as the beginning of a 
line (^setdar) because $ff_filters is a list, as show in line 3781, which is 
converted to a single line of strings separated by spaces. 
ff_filters=$($FFmpeg -filters 2>/dev/null | awk 'f;/Filters:/{f=1}')

The same happens for all the other filter parameters to ffmpeg with ^ at the 
beginning.  

Sorry if I'm missing something. 

Thanks!

Original issue reported on code.google.com by c...@mondueri.com on 27 Nov 2013 at 9:03

GoogleCodeExporter commented 9 years ago 
Hi. Sorry it has taken so long to respond. Thanks for reporting this - I 
actually fixed it 2 days later in SVN and I just noticed I didn't update this 
issue. Please report if the fix doesn't work for you - otherwise I will close 
this issue.

Thanks again for the report!
grepper

Original comment by grepper@gmail.com on 28 Feb 2014 at 6:41

GoogleCodeExporter commented 9 years ago

Original comment by grepper@gmail.com on 21 May 2014 at 1:08