google-code-export / typica

Automatically exported from code.google.com/p/typica
Apache License 2.0
1 stars 1 forks source link

Private IP Address not set correctly in ReservationDescription.Instance constructor #67

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Call DescribeInstances on a fully booted instance
2. Call resulting ReservationDescription.Instance.getPrivateIpAddress()

What is the expected output? What do you see instead?
Actual: null
Expected: private IP address

What version of the product are you using? On what operating system?
r294

Please provide any additional information below.
The argument to the constructor is mis-spelled as privateIpdAddress. The
assignment inside the constructor assigns the (null) member value to itself
instead of the constructor argument value.

Original issue reported on code.google.com by gabriel....@gmail.com on 21 Oct 2009 at 7:09

GoogleCodeExporter commented 9 years ago
Attached is an SVN patch for fixing this bug. Could someone with auth can 
review and 
submit please ?

Index: java/com/xerox/amazonws/ec2/ReservationDescription.java
===================================================================
--- java/com/xerox/amazonws/ec2/ReservationDescription.java (revision 295)
+++ java/com/xerox/amazonws/ec2/ReservationDescription.java (working copy)
@@ -123,7 +123,7 @@
                String dnsName, String stateName, int stateCode, 
String reason,
                String keyName, InstanceType instanceType, Calendar 
launchTime,
                String availabilityZone, String kernelId, String 
ramdiskId, String platform,
-               boolean monitoring, String subnetId, String 
privateIpdAddress, String ipAddress) {
+               boolean monitoring, String subnetId, String 
privateIpAddress, String ipAddress) {
            this.imageId = imageId;
            this.instanceId = instanceId;
            this.privateDnsName = privateDnsName;

Original comment by itaifren...@live.com on 7 Dec 2009 at 11:21

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks, and this has been fixed.

Original comment by dkavan...@gmail.com on 23 Mar 2010 at 11:01