search

google-code-export / uimafit

Automatically exported from code.google.com/p/uimafit
2 stars 1 forks source link

Synchronize initializer method names and signature #27

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Currently the initialization methods are like this:

        ConfigurationParameterInitializer.initializeConfigurationParameters(Component, Context);
        ExternalResourceInitializer.initializeExternalResources(Context, Component);

I think both methods should have the same name and signature. Suggestion:

        ConfigurationParameterInitializer.initialize(Component, Context);
        ExternalResourceInitializer.initialize(Component, Context);

Original issue reported on code.google.com by richard.eckart on 19 Jun 2010 at 2:04

GoogleCodeExporter commented 9 years ago 
Fine by me.  I gave them different names because of your fondness for static 
imports of methods.

Original comment by pvogren@gmail.com on 20 Jun 2010 at 3:43

GoogleCodeExporter commented 9 years ago 
Richard - Can you confirm which name you would prefer?  I am indifferent here.  
initialize() in both places is more consistent.  initializeCP or initializeER 
is better for static imports.  I'll make the change.

Original comment by pvogren@gmail.com on 2 Jul 2010 at 4:11

GoogleCodeExporter commented 9 years ago 
I'd prefer the 

ConfigurationParameterInitializer.initialize(Component, Context);
ExternalResourceInitializer.initialize(Component, Context);

It they weren't static, I'd even suggest to set up an interface.

Original comment by richard.eckart on 3 Jul 2010 at 8:05

GoogleCodeExporter commented 9 years ago

Original comment by pvogren@gmail.com on 7 Jul 2010 at 11:33