google-code-export / wagic

Automatically exported from code.google.com/p/wagic
1 stars 0 forks source link

Kor Haven, makes you invulnerable after using once #272

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
After using it once to prevent damage from a single creature, seems that it
made me and the AI invulnerable to further damage, as the life totals
wouldn't drop an inch even attacked by a horde of 8/8 Angels (like 20-30).

Using Wagic 0.10.1.

Original issue reported on code.google.com by azurhial...@gmail.com on 27 Dec 2009 at 10:35

GoogleCodeExporter commented 9 years ago
Confirmed. We have 7 cards which use code of this format (or similar):

preventAllCombatDamage from target(creature) ueot

This can't work because the parser looks for "from(", not for "from", and this 
probably 
screws up the parsing so that the ueot won't get parsed correctly. Which leads 
to an 
untargeted, unconditional, infinite damage prevention.

Original comment by Psyyri...@gmail.com on 27 Dec 2009 at 11:43

GoogleCodeExporter commented 9 years ago
I'm not sure how preventAllCombatDamage is meant to work for such cases. The 
"from" does 
need to be immediately followed by an identifier enclosed in parentheses. This 
identifier 
can only by "this" or "mytgt", anything else won't work. Specifically, 
from(target
(creature)) will not work: You can target and select the creature, but the 
effect won't 
be applied to it.

We can get around that limitation by adding a separate target specification 
like this:
auto={1}{W}{T}:target(creature[attacking]) preventAllCombatDamage from(mytgt)

This will add the effect to the targeted creature, but it won't be removed at 
end of turn, 
not even when we add "ueot" to the rule.

Original comment by Psyyri...@gmail.com on 28 Dec 2009 at 12:51

GoogleCodeExporter commented 9 years ago
"from(" works like "target(", so instead of from(target(creature)), we should 
write 
from(creature). I don't know if that's your only issue here?

Original comment by wagic.the.homebrew@gmail.com on 28 Dec 2009 at 5:09

GoogleCodeExporter commented 9 years ago
from(creature) will not allow to specify a target, instead the effect will 
affect 
all cards that meet the specified criteria. The effect will also last 
indefinitely, even if ueot is explicitly added. So that's unfortunately not the 
solution.

Original comment by Psyyri...@gmail.com on 28 Dec 2009 at 5:43

GoogleCodeExporter commented 9 years ago
the ueot issue is a different problem. For the time being we should remove these
cards that say from target..., and open a different ticket for ueot issues

Original comment by wagic.the.homebrew@gmail.com on 30 Jan 2010 at 2:07

GoogleCodeExporter commented 9 years ago
Removed Kor Haven and other similar cards from the SVN.
Please open a new issue for any other "prevent damage" bug

Original comment by wagic.the.homebrew@gmail.com on 6 Feb 2010 at 8:24

GoogleCodeExporter commented 9 years ago
Someone has found a way to fix this? This card is very usefull to me... rss

Original comment by Tidi...@gmail.com on 10 Feb 2010 at 1:52

GoogleCodeExporter commented 9 years ago
No, it's been removed from the game for now. That's why the status says "Won't 
fix"

Original comment by wagic.the.homebrew@gmail.com on 10 Feb 2010 at 2:56

GoogleCodeExporter commented 9 years ago
Thanks friend!

Original comment by Tidi...@gmail.com on 10 Feb 2010 at 3:07