Closed GoogleCodeExporter closed 9 years ago
I saw that in R2264, but it was probably introduced before
Original comment by wagic.the.homebrew@gmail.com
on 11 Sep 2010 at 9:02
after running the full test suite:
Dumping objects ->
{3480878} normal block at 0x06A68CC8, 12 bytes long.
Data: < : > 98 18 A7 06 80 8C A6 06 3A 00 00 00
{3480877} normal block at 0x06A68C80, 12 bytes long.
Data: < > C8 8C A6 06 98 18 A7 06 0B 00 00 00
{3480876} normal block at 0x06A68C38, 12 bytes long.
Data: <8 8 > 38 8C A6 06 38 8C A6 06 CD CD CD CD
{3480875} normal block at 0x06A718E0, 12 bytes long.
Data: < > E0 18 A7 06 E0 18 A7 06 CD CD CD CD
{3480874} normal block at 0x06A71898, 12 bytes long.
Data: < > 80 8C A6 06 C8 8C A6 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\include\allabilities.h(2790)
: {3480873} normal block at 0x06A71790, 200 bytes long.
Data: < f > 84 C5 66 00 16 00 00 00 00 00 00 00 00 00 00 00
{3480871} normal block at 0x06A71680, 12 bytes long.
Data: < 8 : > F0 F0 A5 06 38 16 A7 06 3A 00 00 00
{3480870} normal block at 0x06A71638, 12 bytes long.
Data: < > 80 16 A7 06 F0 F0 A5 06 0B 00 00 00
{3480869} normal block at 0x06A6D3A0, 12 bytes long.
Data: < > A0 D3 A6 06 A0 D3 A6 06 CD CD CD CD
{3480868} normal block at 0x06A71230, 12 bytes long.
Data: <0 0 > 30 12 A7 06 30 12 A7 06 CD CD CD CD
{3480867} normal block at 0x06A5E448, 12 bytes long.
Data: <H H > 48 E4 A5 06 48 E4 A5 06 CD CD CD CD
{3480866} normal block at 0x06A5F0F0, 12 bytes long.
Data: <8 > 38 16 A7 06 80 16 A7 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\src\mtgability.cpp(1182) :
{3480865} normal block at 0x06A71518, 224 bytes long.
Data: <d f > 64 C4 66 00 16 00 00 00 00 00 00 00 00 00 00 00
{3471100} normal block at 0x06A714D0, 12 bytes long.
Data: < : > B0 13 A7 06 88 14 A7 06 3A 00 00 00
{3471099} normal block at 0x06A71488, 12 bytes long.
Data: < > D0 14 A7 06 B0 13 A7 06 0B 00 00 00
{3471098} normal block at 0x06A71440, 12 bytes long.
Data: <@ @ > 40 14 A7 06 40 14 A7 06 CD CD CD CD
{3471097} normal block at 0x06A713F8, 12 bytes long.
Data: < > F8 13 A7 06 F8 13 A7 06 CD CD CD CD
{3471096} normal block at 0x06A713B0, 12 bytes long.
Data: < > 88 14 A7 06 D0 14 A7 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\include\allabilities.h(2790)
: {3471095} normal block at 0x06A5F6D0, 200 bytes long.
Data: < f > 84 C5 66 00 16 00 00 00 00 00 00 00 00 00 00 00
{3471093} normal block at 0x06A5F5C0, 12 bytes long.
Data: <h x : > 68 C6 A6 06 78 F5 A5 06 3A 00 00 00
{3471092} normal block at 0x06A5F578, 12 bytes long.
Data: < h > C0 F5 A5 06 68 C6 A6 06 0B 00 00 00
{3471091} normal block at 0x06A5F530, 12 bytes long.
Data: <0 0 > 30 F5 A5 06 30 F5 A5 06 CD CD CD CD
{3471090} normal block at 0x06A5F4E8, 12 bytes long.
Data: < > E8 F4 A5 06 E8 F4 A5 06 CD CD CD CD
{3471089} normal block at 0x06A4B0D8, 12 bytes long.
Data: < > D8 B0 A4 06 D8 B0 A4 06 CD CD CD CD
{3471088} normal block at 0x06A6C668, 12 bytes long.
Data: <x > 78 F5 A5 06 C0 F5 A5 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\src\mtgability.cpp(1182) :
{3471087} normal block at 0x06A5F3C8, 224 bytes long.
Data: <d f > 64 C4 66 00 16 00 00 00 00 00 00 00 00 00 00 00
{3458581} normal block at 0x06A5F310, 12 bytes long.
Data: <` 8 : > 60 87 A6 06 38 88 A6 06 3A 00 00 00
{3458580} normal block at 0x06A68838, 12 bytes long.
Data: < ` > 10 F3 A5 06 60 87 A6 06 0B 00 00 00
{3458579} normal block at 0x06A687F0, 12 bytes long.
Data: < > F0 87 A6 06 F0 87 A6 06 CD CD CD CD
{3458578} normal block at 0x06A687A8, 12 bytes long.
Data: < > A8 87 A6 06 A8 87 A6 06 CD CD CD CD
{3458577} normal block at 0x06A68760, 12 bytes long.
Data: <8 > 38 88 A6 06 10 F3 A5 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\include\allabilities.h(2790)
: {3458576} normal block at 0x06A68658, 200 bytes long.
Data: < f > 84 C5 66 00 16 00 00 00 00 00 00 00 00 00 00 00
{3458574} normal block at 0x06A68548, 12 bytes long.
Data: <` : > 60 1E A6 06 80 E9 A2 06 3A 00 00 00
{3458573} normal block at 0x06A2E980, 12 bytes long.
Data: <H ` > 48 85 A6 06 60 1E A6 06 0B 00 00 00
{3458572} normal block at 0x06A5E600, 12 bytes long.
Data: < > 00 E6 A5 06 00 E6 A5 06 CD CD CD CD
{3458571} normal block at 0x06A6C700, 12 bytes long.
Data: < > 00 C7 A6 06 00 C7 A6 06 CD CD CD CD
{3458570} normal block at 0x06A627D8, 12 bytes long.
Data: < ' ' > D8 27 A6 06 D8 27 A6 06 CD CD CD CD
{3458569} normal block at 0x06A61E60, 12 bytes long.
Data: < H > 80 E9 A2 06 48 85 A6 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\src\mtgability.cpp(1182) :
{3458568} normal block at 0x06A68428, 224 bytes long.
Data: <d f > 64 C4 66 00 16 00 00 00 00 00 00 00 00 00 00 00
{3149626} normal block at 0x06A319A0, 12 bytes long.
Data: <( P 9 > 28 A5 A6 06 50 C9 A2 06 39 00 00 00
{3149625} normal block at 0x06A2C950, 12 bytes long.
Data: < ( > A0 19 A3 06 28 A5 A6 06 0B 00 00 00
{3149624} normal block at 0x06A476B0, 12 bytes long.
Data: < v v > B0 76 A4 06 B0 76 A4 06 CD CD CD CD
{3149623} normal block at 0x06A45298, 12 bytes long.
Data: < R R > 98 52 A4 06 98 52 A4 06 CD CD CD CD
{3149622} normal block at 0x06A6A528, 12 bytes long.
Data: <P > 50 C9 A2 06 A0 19 A3 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\include\allabilities.h(2790)
: {3149621} normal block at 0x06A61180, 200 bytes long.
Data: < f > 84 C5 66 00 15 00 00 00 00 00 00 00 00 00 00 00
{3149619} normal block at 0x06A3B468, 12 bytes long.
Data: <@ x 9 > 40 BA A2 06 78 1F A6 06 39 00 00 00
{3149618} normal block at 0x06A61F78, 12 bytes long.
Data: <h @ > 68 B4 A3 06 40 BA A2 06 0B 00 00 00
{3149617} normal block at 0x06A60C60, 12 bytes long.
Data: <` ` > 60 0C A6 06 60 0C A6 06 CD CD CD CD
{3149616} normal block at 0x06A48F68, 12 bytes long.
Data: <h h > 68 8F A4 06 68 8F A4 06 CD CD CD CD
{3149615} normal block at 0x06A49A18, 12 bytes long.
Data: < > 18 9A A4 06 18 9A A4 06 CD CD CD CD
{3149614} normal block at 0x06A2BA40, 12 bytes long.
Data: <x h > 78 1F A6 06 68 B4 A3 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\src\mtgability.cpp(1182) :
{3149613} normal block at 0x06A5E730, 224 bytes long.
Data: <d f > 64 C4 66 00 15 00 00 00 00 00 00 00 00 00 00 00
{2571433} normal block at 0x06A5B8D0, 12 bytes long.
Data: < > D0 B8 A5 06 D0 B8 A5 06 CD CD CD CD
{2571432} normal block at 0x06A5B888, 12 bytes long.
Data: < > 00 09 A6 06 00 09 A6 06 06 00 00 00
{2571431} normal block at 0x06A60900, 12 bytes long.
Data: < > 88 B8 A5 06 88 B8 A5 06 CD CD CD CD
{2571430} normal block at 0x06A5DE58, 12 bytes long.
Data: <X X > 58 DE A5 06 58 DE A5 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\include\allabilities.h(2761)
: {2571429} normal block at 0x06A5DD50, 200 bytes long.
Data: < f > 84 C5 66 00 15 00 00 00 00 00 00 00 01 00 00 00
{2569340} normal block at 0x06A38460, 12 bytes long.
Data: < > F8 FA A3 06 F8 FA A3 06 06 00 00 00
{2569339} normal block at 0x06A348D8, 12 bytes long.
Data: < H H > D8 48 A3 06 D8 48 A3 06 CD CD CD CD
{2569338} normal block at 0x06A3FAF8, 12 bytes long.
Data: <` ` > 60 84 A3 06 60 84 A3 06 CD CD CD CD
{2569337} normal block at 0x06A4C578, 12 bytes long.
Data: <x x > 78 C5 A4 06 78 C5 A4 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\include\allabilities.h(2790)
: {2569336} normal block at 0x06A61008, 200 bytes long.
Data: < f > 84 C5 66 00 15 00 00 00 00 00 00 00 00 00 00 00
{2569334} normal block at 0x06A40178, 12 bytes long.
Data: < > 88 1E A4 06 88 1E A4 06 06 00 00 00
{2569333} normal block at 0x06A6D6A0, 12 bytes long.
Data: < > A0 D6 A6 06 A0 D6 A6 06 CD CD CD CD
{2569332} normal block at 0x06A4B7E0, 12 bytes long.
Data: < > E0 B7 A4 06 E0 B7 A4 06 CD CD CD CD
{2569331} normal block at 0x06A41E88, 12 bytes long.
Data: <x x > 78 01 A4 06 78 01 A4 06 CD CD CD CD
{2569330} normal block at 0x06A6A868, 12 bytes long.
Data: <h h > 68 A8 A6 06 68 A8 A6 06 CD CD CD CD
c:\users\erwan\desktop\programming\wth\projects\mtg\src\mtgability.cpp(1182) :
{2569329} normal block at 0x06A3AA60, 224 bytes long.
Data: <d f > 64 C4 66 00 15 00 00 00 00 00 00 00 00 00 00 00
c:\users\erwan\desktop\programming\wth\projects\mtg\src\mtgability.cpp(1095) :
{1394232} normal block at 0x06A3D688, 132 bytes long.
Data: < f > A4 C3 66 00 16 00 00 00 00 00 00 00 00 00 00 00
Original comment by wagic.the.homebrew@gmail.com
on 11 Sep 2010 at 2:34
ekk, translation in english requested...
which abilities is it reffering to?
Original comment by omegabla...@gmail.com
on 11 Sep 2010 at 2:39
[deleted comment]
nevermind again, its that i was reserving memory for ints and not freeing it
up, fixed 2 of the leaks i caused...have one more that im not sure how to fix,
since i cant "delete iteratorlist" the rest have to do with leaks in other
non-zeth related coding lol.
Original comment by omegabla...@gmail.com
on 11 Sep 2010 at 4:58
fixed 3 leaks with transforms( only other leaks i can claim are bloodthirst
ability, not sure if its the "int amount" causing it...but it saids i cant
"delete items that are not pointers...so im stuck on that one...the rest of the
leaks are in the shop, in deck, and other code not related to my additions.
Original comment by omegabla...@gmail.com
on 11 Sep 2010 at 6:04
Thanks a lot. I fixed some of them myself, which are unrelated to card codes.
The last one seems to be related to "bloodthirst". The formatting of the code
(alignment of "if/else") is very weird in the part of the code, so please
double check that (I will too), maybe it's not doing what you are really
expecting.
Original comment by wagic.the.homebrew@gmail.com
on 12 Sep 2010 at 5:48
after cleaning up the formatting, the code seems good. It would be good to
identify which test is creating this memory leak (most likely a test with
"bloodthirst"), and run this test alone to see what's going on in more details.
If you know which test it is, please let me know :)
Original comment by wagic.the.homebrew@gmail.com
on 12 Sep 2010 at 5:50
well the only allocated memory that bloodthirst code still be holding is in the
int for amount. at the pointer amount(amount), i might be completely incorrect
tho lol. do you have a submission with the realignment of bloodthirst so i
might compare differences and learn from my mistake :)
Original comment by omegabla...@gmail.com
on 12 Sep 2010 at 6:14
After r2271 there still one memory leaks for this issue.
Detected memory leaks!
Dumping objects ->
d:\documents\projects\wagic\projects\mtg\src\mtgability.cpp(1095) : {210023}
normal block at 0x06BBEEC8, 132 bytes long.
Data: <, j > 2C 86 6A 00 16 00 00 00 00 00 00 00 00 00 00 00
Object dump complete.
I guess r2209 might be reviewed for this leak.
I don't known if it can be fixed by following way and maybe someone can look
into it.
Index: projects/mtg/include/AllAbilities.h
===================================================================
--- projects/mtg/include/AllAbilities.h (revision 2271)
+++ projects/mtg/include/AllAbilities.h (working copy)
@@ -2611,7 +2611,7 @@
if(_target->controller()->opponent()->damaged() > 0){
_target->counters->addCounter(1,1);}
}
- return 1;}
+ return MTGAbility::addToGame();}
ABloodThirst * clone() const{
ABloodThirst * a = NEW ABloodThirst(*this);
a->isClone = 1;
Original comment by linshier@gmail.com
on 12 Sep 2010 at 8:20
ran debugger and all test, no leaks returned...this issue is solved unless you
guys are still getting leaks.
Original comment by omegabla...@gmail.com
on 15 Sep 2010 at 6:14
No more memory leaks when running the test suite as of r2289
Original comment by wagic.the.homebrew@gmail.com
on 18 Sep 2010 at 4:07
Original issue reported on code.google.com by
wagic.the.homebrew@gmail.com
on 11 Sep 2010 at 8:59