Non-basic lands "mana ability" uses the stack and passes priority

google-code-export / wagic

Automatically exported from code.google.com/p/wagic

1 stars 0 forks source link

Non-basic lands "mana ability" uses the stack and passes priority #456

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. AI sacrifice Mogg Fanatic to damage my Ball Lightning.
2. I tap forest and Shivan Oasis to add 2 mana for using Fling (Ball Lightning).
3. AI sacrifice another Mogg Fanatic to damage my Ball Lightning(same target).
4.Screen show stack windows,and AI success destory my Ball Lightning.
5.Then Shivan Oasis add red mana.....

What version of the product are you using? On what operating system?
PSP 5.00M33 + Wagic 12.0.1（Follow update to R2291）

Please provide any additional information below.
I think land don't need in stack.

Original issue reported on code.google.com by tzu...@gmail.com on 19 Sep 2010 at 4:41

GoogleCodeExporter commented 9 years ago

mana abilities should NEVER use the stack, the issue here is not what cards 
were involved, altho you are using an unsupported card, it has been reported by 
others that mana during interupts is putting the mana ability on the stack. 
this includes land. which is then passing priority BACK to the ai.

Original comment by omegabla...@gmail.com on 19 Sep 2010 at 9:32

Changed title: lands "mana ability" uses the stack and passes priority
Added labels: Priority-High
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

This issue is quiet annoying and makes the responding on opponent's spells a 
nuisance!

Original comment by dan.solo...@googlemail.com on 19 Sep 2010 at 9:34

GoogleCodeExporter commented 9 years ago

Original comment by omegabla...@gmail.com on 21 Sep 2010 at 10:43

Added labels: Priority-Medium
Removed labels: Priority-High

GoogleCodeExporter commented 9 years ago

Original comment by omegabla...@gmail.com on 27 Sep 2010 at 2:19

Changed title: Non-basic lands "mana ability" uses the stack and passes priority

GoogleCodeExporter commented 9 years ago

Original comment by omegabla...@gmail.com on 10 Nov 2010 at 6:00

Added labels: Priority-Low
Removed labels: Priority-Medium

GoogleCodeExporter commented 9 years ago

i commited a fix for this preventing genericability from "side sending" a tap 
event due to a possibly overlooked variable doTap defaulted to "1"(aka 
tap)...and added handling for it in genericability resolve...as per mtg rules, 
if an ability no matter the effects which lead to it, were to ADD MANA, then it 
is a mana producing ability and does not use the stack nor offer the other 
player a chance to respond. 

leaving this ticket open until someone else varified the fix.

Original comment by omegabla...@gmail.com on 1 Feb 2011 at 2:32

GoogleCodeExporter commented 9 years ago

Fix confirmed. Finally this is gone.

Thanks alot!

Original comment by dan.solo...@googlemail.com on 1 Feb 2011 at 7:34

GoogleCodeExporter commented 9 years ago

Original comment by dan.solo...@googlemail.com on 1 Feb 2011 at 7:35

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

I believe I have a very clean fix for this issue. I know it was supposed to be 
fixed, but I encountered it in Triggered Abilities while working on a different 
thing, so I think your fix was not enough.
I am wondering if you happen to know:
- If we have a test for this issue
- If you remember the revision where you fixed this issue (need to see if my 
fix is enough and if we can cleanup some code here and there)

Original comment by wagic.the.homebrew@gmail.com on 6 May 2011 at 8:44