@tapped trigger and declaring combat attackers = profit!

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Veteran of the Depths
2. delcare as attacker, undeclare, declare as attacker, undeclare, repeat
3. profit!

What is the expected output? What do you see instead?
@tapped triggers every time hes declared and undeclared.

possible fix:
have the ->tap() for attackers moved from react to click attacker rule.
and add a Weventrecieved phasechange == blockers tap all the declared 
attackers...

instead of tapping them. maybe add a sheild and sword icon on the card, like 
the symbols that appear on basic lands when they do not have images.

this will let the player know its declared....when player request the next 
phase. and Weventphasechange to == blockers. have the attackers rule tap all 
creature->isattacker() == 1.

this exploit is not just in this card, but ALL cards with @tapped trigger.

the reason i suggest having attackers rule handle it instead of altering 
@tapped trigger, is that currently @tapped works to well to add restrictions 
based on combat, also it IS supposed to trigger for creatures being declared as 
attackers...except in wagic, you can "tap/untap/tap/untap" when you declare the 
attackers...so it is a serious exploit.

Original issue reported on code.google.com by omegabla...@gmail.com on 2 Oct 2010 at 12:49

[GoogleCodeExporter]

NOTE: this only effects attackers phase. since blockers do not tap when 
declared as a blocker.

Original comment by omegabla...@gmail.com on 2 Oct 2010 at 12:52

[GoogleCodeExporter]

[deleted comment]

[GoogleCodeExporter]

also note, already atempted this suggested fix, works fine. however, i do not 
know how to make it add a cool symbol or any kind of visual queqe that a card 
is declared, so combat phase declaring attackers became very confusing without 
knowing if i already declared it.

Original comment by omegabla...@gmail.com on 2 Oct 2010 at 1:01

[GoogleCodeExporter]

instead of tapping them. maybe add a sheild and sword icon on the card, like 
the symbols that appear on basic lands when they do not have images.

further explanation of what i mean when i say this
DURING attackers...do not have cards tap, instead slap a cool icon on the cards 
that are "declared" as attackers. even have them move into the combat zone. 
just DO NOT TAP THEM, until the player request blockers phase.

soon as it is requested, the icon should vanish, and the card should tap. THEN 
"blocker phase" begins. NOTE: the only thing that should change is WHEN a card 
becomes tapped during attackers phase. nothing else. instead of tapping use an 
icon symbol to display that it is declared.

Original comment by omegabla...@gmail.com on 2 Oct 2010 at 1:05

[GoogleCodeExporter]

moved the tapping of declared attackers to the END of attackers phase.

Original comment by omegabla...@gmail.com on 3 Oct 2010 at 2:20

• Changed state: Fixed

[GoogleCodeExporter]

Tapping the creatures at the end of the Declare Attackers Step is technically 
incorrect. For example, I should be able to use Royal Assassin's ability to 
destroy a tapped attacker before I declare my blockers during the Declare 
Attackers Step.

Original comment by mathew.h...@gmail.com on 5 Oct 2010 at 5:07

[GoogleCodeExporter]

mathew, altho i agree with you. i see NOTHING at all stopping you from doing 
this action at the beginning of blockers step.

where the tapping and untapping of cards was an exploit that effected many 
cards.

Original comment by omegabla...@gmail.com on 7 Oct 2010 at 11:18

[GoogleCodeExporter]

i will also note, this doesnt change any of the previous methods you would have 
done this action anyways....

since Ai declares its attackers all at once and all instantly and heads 
directly to blcokers steps BEFORE you could even blink your eyes.

unless you wanted to destroy one of your own creatures...if this is the case 
please provide an instence where doing it in blockers step would be a probelm.

Original comment by omegabla...@gmail.com on 7 Oct 2010 at 11:22

[GoogleCodeExporter]

My opponent attacks with a Prized Unicorn and a Yavimaya Wurm. I have a Royal 
Assassin and two Black Knights. In this case, I have to destroy the Prized 
Unicorn before I declare my blockers if I want to block the Yavimaya Wurm.

I can work around this by using the ability while declaring blockers, but 
allowing the use of spells and abilities while declaring attackers or blockers 
causes issues like this http://code.google.com/p/wagic/issues/detail?id=160

Original comment by mathew.h...@gmail.com on 10 Oct 2010 at 7:23

[GoogleCodeExporter]

My opponent attacks with a Prized Unicorn and a Yavimaya Wurm. <----

i will repeat.
and i quote:
i will also note, this doesnt change any of the previous methods you would have 
done this action anyways....
since Ai declares its attackers all at once and all instantly and heads 
directly to blcokers steps BEFORE you could even blink your eyes.

end quote.

you were not able to do this before this change. so this change did nothing to 
change the way you would currently have done it. BTW if youre on current 
release and not SVN version. you can verify what im saying is true. 

even in current SVN version this is true but i want you to notice that even 
before this change, this is true.

Original comment by omegabla...@gmail.com on 10 Oct 2010 at 2:09