google-code-export / win7shell

Automatically exported from code.google.com/p/win7shell
2 stars 0 forks source link

Version 1.09 broke album art for me #159

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Install version 1.09 of the plug-in.
2. Start Winamp and start playing a song.
3. Hold mouse over the taskbar button and you'll see the play control
buttons, but no album art and no song title.

I expected to see the album art with the info I configured. Instead I see
the normal preview for WinAMP as if the plug-in was not installed.

What version of Winamp are you using? What plugin version? On what
operating system?
Winamp 5.56, plugin 1.09 on Windows 7 x64.

Please provide any additional information below.

Original issue reported on code.google.com by gule...@gmail.com on 30 Oct 2009 at 5:46

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
i am actually getting this problem too
some of my songs even if it shows the album art on winamp it does not show on 
the
win7shell
What version of Winamp are you using? What plugin version? On what
operating system?
Winamp 5.56, plugin 1.09 on Windows 7 x64.

Original comment by ImBZ...@gmail.com on 30 Oct 2009 at 6:49

GoogleCodeExporter commented 9 years ago
Meh, it's obvious... Everything has to break, even if I didn't touch them...
Anyways, I'm not home all weekend, so can't look into it now.

Original comment by att...@gmail.com on 30 Oct 2009 at 10:26

GoogleCodeExporter commented 9 years ago
Okay, I'm back and I need more info on this one... Did you try reinstall or 
w/e? It
doesn't find any album art? Tried with local files / embedded picture / ID3 / 
APE tag?

Original comment by att...@gmail.com on 2 Nov 2009 at 8:26

GoogleCodeExporter commented 9 years ago
I just tried a re-install, but that didn't fix anything. I tried downgrading to 
1.08,
but that didn't seem to work anymore either. I deleted the settings and tried, 
still
no go.

So far I've seen not a single MP3 where the album art worked, although the 
Winamp
album art window itself does show the album art correctly.
I have all the album art embedded in the ID3 tag of the MP3 file.

Original comment by gule...@gmail.com on 2 Nov 2009 at 8:44

GoogleCodeExporter commented 9 years ago
Okay, that's disturbing ... how come 1.08 doesn't work anymore? :/
I could do a "special" plug-in, that would write out each step to a file, and 
see
what's wrong, because like this i'm like ... no idea what's going on.

Original comment by att...@gmail.com on 2 Nov 2009 at 9:06

GoogleCodeExporter commented 9 years ago
Seeing as how 1.08 used to work, but now stopped, maybe I should try to reboot. 
I
hibernate my machine every time, so I hardly get any reboots. Last time with 
1.08 I
noticed weird things happing, like windows from other programs having drawing
artifacts and weird control positioning. I've had that before so I had an idea 
and
when I took a look in the task manager it was confirmed: Winamp was using 
10.000 GDI
objects. So I guess 1.08 has a serious resource leak. I then restarted Winamp 
and
then it told me about 1.09. But I never rebooted. I will try that now.

Original comment by gule...@gmail.com on 2 Nov 2009 at 9:59

GoogleCodeExporter commented 9 years ago
I've checked the leak issue several times, since I had a suspicion about it, 
but at
that time it seemed okay. 
Btw, how did you check those GDI objects? :/

Original comment by att...@gmail.com on 2 Nov 2009 at 10:08

GoogleCodeExporter commented 9 years ago
Reboot seemed to have fixed it. The GDI subsystem must've been frakked or 
something.
I checked the GDI object usage through the standard task manager. Go to the
"Processes" tab. Then open the "View" menu and click "Select columns". From 
there you
can add all kinds of interesting metrics. One of them is "GDI Objects".
Another way is to use the Performance Monitor. You can see a history through 
that
tool, or you can use my favourite tool: Process Explorer.

Original comment by gule...@gmail.com on 2 Nov 2009 at 10:12

GoogleCodeExporter commented 9 years ago
Okay, thanks for the info, I will track down the leak. :)

Original comment by att...@gmail.com on 2 Nov 2009 at 10:16

GoogleCodeExporter commented 9 years ago
Issue 176 has been merged into this issue.

Original comment by att...@gmail.com on 2 Nov 2009 at 10:55

GoogleCodeExporter commented 9 years ago
Found all memory leaks, and fixed them in 1.10.
Thanks for noticing and reporting this :)

Original comment by att...@gmail.com on 4 Nov 2009 at 8:36