Modify class ButtonIcon to accept enumeration for icons

[GoogleCodeExporter]

Reuse icons  enumeration on ThemeUiHelper class to allow ButtonIcon to have a 
constructor receiving the enumeration. I made the enumeration a standalone 
class and renamed it to UiIcon. 

TODO: IMO it would be nice if enum contants are named as similar as possible to 
UI icon names. E.g. instead CARAT_1_NORTH have carat_1_n. or both?

Original issue reported on code.google.com by reier...@gmail.com on 18 Oct 2010 at 1:43

Attachments:

• wiquery-1.1-SNAPSHOT-icons.patch

[GoogleCodeExporter]

Hi Ernesto,

I'm agreed with you to create a new constructor into the button to specify the 
icon. However, I see you create a new enumeration class and destroy the old one 
from the Theme class helper. 

I think we have to use the old enum to preserve code where we use it. What do 
you think ? Maybe we can declare the old enum as a depracted enum, create the 
new enum with the similar names and creates into the theme helper methods which 
use this new enum.

Cheers

Julien Roche

Original comment by roche....@gmail.com on 18 Oct 2010 at 9:08

• Added labels: 1.1

[GoogleCodeExporter]

Original comment by roche....@gmail.com on 18 Oct 2010 at 9:09

• Added labels: Milestone-Release1.1
• Removed labels: 1.1

[GoogleCodeExporter]

Julien, 

Ok. I will do that.

Cheers,

Ernesto

Original comment by reier...@gmail.com on 19 Oct 2010 at 2:23

[GoogleCodeExporter]

fixed on commit http://code.google.com/p/wiquery/source/detail?r=462

Original comment by reier...@gmail.com on 19 Oct 2010 at 5:37

• Changed state: Fixed