search

google-code-export / wiquery

Automatically exported from code.google.com/p/wiquery
MIT License
1 stars 1 forks source link

Options incorrectly returns this for getWrappedModel() #138

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Since 1.1, the Options class implements IWrapModel<Options> and this method is 
added:

public IModel<?> getWrappedModel() {
    return this;
} 

In Wicket 1.4.14, this behavior seems to be invalid. When using the Options 
class on my pages, the following exception is thrown: 

org.apache.wicket.WicketRuntimeException: Model for 
org.odlabs.wiquery.core.options.Options@54f12ffb is self-referential
     at org.apache.wicket.Component.getInnermostModel(Component.java:3738)
     at org.apache.wicket.Component.sameInnermostModel(Component.java:2832)
     at org.apache.wicket.Component.sameInnermostModel(Component.java:2815)
     at org.apache.wicket.Page$6.component(Page.java:1497)
     at org.apache.wicket.MarkupContainer.visitChildren(MarkupContainer.java:899)
     at org.apache.wicket.MarkupContainer.visitChildren(MarkupContainer.java:914)
     at org.apache.wicket.MarkupContainer.visitChildren(MarkupContainer.java:939)
     at org.apache.wicket.Page.internalOnModelChanged(Page.java:1492)
     at org.apache.wicket.Component.modelChanged(Component.java:2249)
     at org.apache.wicket.Component.setDefaultModel(Component.java:3048)
     at org.apache.wicket.MarkupContainer.setDefaultModel(MarkupContainer.java:773)

Original issue reported on code.google.com by norc...@gmail.com on 29 Nov 2010 at 1:08

GoogleCodeExporter commented 9 years ago 
This has already been fixed on trunk (will be future 1.2 release). We could try 
to apply the same patch to 1.x branch and release a 1.1.2? 

Ernesto

Original comment by reier...@gmail.com on 29 Nov 2010 at 1:23

GoogleCodeExporter commented 9 years ago 
Hi Ernesto,

Can you wait the close of the issue 139 please ? (I woulid like to now if this 
bug or not). Otherwise, I'm agreed for a new release release (with a migration 
with Wicket 1.4.14).

Cheers

Julien Roche

Original comment by roche....@gmail.com on 29 Nov 2010 at 1:33

GoogleCodeExporter commented 9 years ago 
Julien,

It seem issue 139 was invalid after all: if proven otherwise we can reopen it.

Cheers,

Ernesto

Original comment by reier...@gmail.com on 29 Nov 2010 at 2:01

GoogleCodeExporter commented 9 years ago 
Ernesto,

Yep, the issue 139 is invalide. So you can push a new release.

See you.

Julienn

Original comment by roche....@gmail.com on 29 Nov 2010 at 2:27

GoogleCodeExporter commented 9 years ago

Original comment by roche....@gmail.com on 1 Dec 2010 at 7:22