google-code-export / wiquery

Automatically exported from code.google.com/p/wiquery
MIT License
1 stars 1 forks source link

IndicatingAjaxLink causes problem in AjaxIndicatorAppender #213

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I reported an Error to the wicket Team. They fixed it, but however they believe 
that in Wiquery there is something left to fix:

In an AjaxEditalbeLabel we set an int - that will reload a dataview with number 
of lines as given in the AjaxEditingLabel.  

In that dataview we use IndicatingAjaxLink to sort the columns. With Wicket 
1.4.18 that worked well.

With Wicket/Wiquery 1.5.0 in this scenario, if the AjaxEditalbeLabels 
onSubmit(...) Method is called, an error occurred:
Root cause:
java.lang.IllegalArgumentException: Argument 'id' may not be null.
at org.apache.wicket.util.lang.Args.notNull(Args.java:39)
at 
org.odlabs.wiquery.core.AbstractWiQueryDecoratingHeaderResponse.renderJavaScript
(AbstractWiQueryDecoratingHeaderResponse.java:128)
at 
org.apache.wicket.extensions.ajax.markup.html.AjaxIndicatorAppender.renderHead(A
jaxIndicatorAppender.java:71)
at org.apache.wicket.Component.renderHead(Component.java:2662)
...

We found that the AjaxIndicatorAppender.renderHead calls the 
org.odlabs.wiquery.core.AbstractWiQueryDecoratingHeaderResponse.renderJavaScript
(someJavaScript, null) 
The method renderJavaScript expicitly checks if the second parameter is null 
and throws an Error here.

Igor Vayenberg let me know that wicket was calling the wrong method (fix will 
be in Wicket1.5.2) but the null value is an valid parameter, so your check if 
ID is null is not valid.

See 
https://issues.apache.org/jira/browse/WICKET-4096?focusedCommentId=13117498#comm
ent-13117498

As a work around we use the AjaxLink  ... .

Thank you,
Marcus

Original issue reported on code.google.com by Marcus.B...@gmail.com on 29 Sep 2011 at 6:26

GoogleCodeExporter commented 9 years ago
please use 1.5.1

Original comment by hielke.hoeve on 26 Oct 2011 at 6:58