search

google-code-export / wiquery

Automatically exported from code.google.com/p/wiquery
MIT License
1 stars 1 forks source link

decorator related logic missing for AjaxBehaviors #80

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
AbstractDefaultAjaxBehavior contains a lot of logic that allows to put 
decorators to Ajax behavior classes. See method.

protected CharSequence generateCallbackScript(final CharSequence partialCall) {

}

All this logic is missing on WiQuery AjaxBehaviours (e.g. DraggableAjaxBehavior 
or DroppableAjaxBehaviour). It would be nice to have them so that we can do 
things like showing bussy indicatiors while AJAX operations are performed. I'll 
try to produce a patch against 1.0.2.

Original issue reported on code.google.com by reier...@gmail.com on 5 Aug 2010 at 12:57

GoogleCodeExporter commented 9 years ago 
I attach a patch of a modified DroppableAjaxBehavior that reuses the logic 
regarding IAjaxCallDecorator present on AbstractDefaultAjaxBehavior. For 
instance, this can be used to decorate the Ajax call so that is shows a loading 
image r display some error message is the AJAX request fails.

Original comment by reier...@gmail.com on 6 Aug 2010 at 7:22

Attachments:

GoogleCodeExporter commented 9 years ago 
Same for Draggable

Original comment by reier...@gmail.com on 6 Aug 2010 at 7:57

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by reier...@gmail.com on 6 Aug 2010 at 7:58

Attachments:

GoogleCodeExporter commented 9 years ago 
I have tested, on one of my applications, the patches above and they seem to 
work fine. Are there any other applications where they can be tested?

Original comment by reier...@gmail.com on 6 Aug 2010 at 10:32

GoogleCodeExporter commented 9 years ago

Original comment by roche....@gmail.com on 10 Aug 2010 at 7:33

GoogleCodeExporter commented 9 years ago 
Fix in commit r358

Original comment by roche....@gmail.com on 15 Aug 2010 at 6:28

GoogleCodeExporter commented 9 years ago 
Hi Julien, 

There were some other behaviors exhibiting the same problem (namely, 
SortableAjaxBehavior, ResizableAjaxBehavior, SelectableAjaxBehavior) as well as 
class ButtonAjax on 1.1.experiment branch. Additionally, implementation of 
DraggableAjaxBehavior for 1.1.experiment was missing the feature for STOP event.

I attach patch for those. Can you please review them?

Cheers,

Ernesto

Original comment by reier...@gmail.com on 16 Aug 2010 at 10:58

Attachments:

GoogleCodeExporter commented 9 years ago 
no problems, I will look it this week

Original comment by roche....@gmail.com on 16 Aug 2010 at 7:41

GoogleCodeExporter commented 9 years ago 
patches has been applied on both branches

Original comment by reier...@gmail.com on 17 Aug 2010 at 7:30

GoogleCodeExporter commented 9 years ago 
Ok thanks

Original comment by roche....@gmail.com on 17 Aug 2010 at 7:56