google-code-export / wro4j

Automatically exported from code.google.com/p/wro4j
1 stars 1 forks source link

RubySassEngine should allow for "sass" syntax - currently hardcoded to "scss" #767

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. attempt to pre-process a "sass" formatted file (as opposed to scss) with 
RubySassCssProcessor (or by extension, BourbonCssProcessor)

What is the expected output? What do you see instead?

expected: properly rendered CSS
result: Exception thrown, ruby engine unable to parse "sass" formatted input 
given "scss" configuration

What version of the product are you using? On what operating system?

wro4j-extensions 1.7.0

Please provide any additional information below.

RubySassEngine could be constructed with an enum Syntax { scss, sass } and have 
separate processor types:

RubySassCssProcessor
RubyScssCssProcessor
BourbonCssProcessor
BourbonCssProcessor

Original issue reported on code.google.com by blue.tho...@gmail.com on 26 Jul 2013 at 9:59

GoogleCodeExporter commented 9 years ago
Whoops - suggested: 

BourbonSassCssProcessor
BourbonScssCssProcessor

Original comment by blue.tho...@gmail.com on 26 Jul 2013 at 10:07

GoogleCodeExporter commented 9 years ago
I don't think I understand, how exactly the RubySassEngine implementation 
should change, in order to allow constructing different processor types?

Original comment by alex.obj...@gmail.com on 18 Aug 2013 at 10:47