google-code-export / wro4j

Automatically exported from code.google.com/p/wro4j
1 stars 1 forks source link

broken when including jQuery 1.10.x #823

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a group which includes jQuery 1.10.x
2. Use the group on a page

What is the expected output? What do you see instead?
Expected output is loading of the jQuery library and objects.  Instead, errors 
are encountered.

What version of the product are you using? On what operating system?
1.6.3

Please provide any additional information below.
Here is the wro.xml which fails:

<?xml version="1.0" encoding="UTF-8"?>
<groups xmlns="http://www.isdc.ro/wro"
        xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
        xsi:schemaLocation="http://www.isdc.ro/wro wro.xsd">

  <group name="main">
    <group-ref>jquery</group-ref>
    <group-ref>theme</group-ref>
    <group-ref>subModal</group-ref>
  </group>

  <group name="jquery">
    <js>https://rccdn.cachefly.net/js/jquery-1.10.2.min.js</js>
    <js>https://rccdn.cachefly.net/js/jquery-migrate-1.2.1.min.js</js>
    <js>https://rccdn.cachefly.net/js/jquery-ui-1.9.2.custom.min.js</js>

    <js>/js/jquery.metadata.js</js>
    <js>/js/jquery.cookie.js</js>
    <js>/js/jquery.caret.js</js>
  </group>

  <group name="theme">
    <css>/css/ui-lightness/jquery-ui-1.9.2.custom.min.css</css>
  </group>

   <group name="tablesorter">
    <js>/js/jquery.tablesorter.min.js</js>
    <js>/js/jquery.tablesorter.widgets.min.js</js>
    <css>/js/tablesorter/style.css</css>
  </group>

  <group name="subModal">
    <js></js>
    <css>/ui/subModal/style.css</css>
    <css>/ui/subModal/subModal.css</css>
    <js>/ui/subModal/common.js</js>
    <js>/ui/subModal/subModal.js</js>
  </group>

</groups>

Original issue reported on code.google.com by st...@regattacentral.com on 9 Dec 2013 at 6:48

GoogleCodeExporter commented 9 years ago
Could you try using latest version (1.7.2) ?

Also, could you provide more details, like configurations options, processors 
used, etc..

Original comment by alex.obj...@gmail.com on 9 Dec 2013 at 6:54

GoogleCodeExporter commented 9 years ago
Alex,

Thanks for the super-fast response!   I don't see the 1.7.2 release in the 
downloads. I assume I need to clone that and build the jar manually.  I'll work 
on that and get back with you.   (we're still on CVS and haven't moved to Maven 
or Git, although that is in the works)

Thanks,
Seve

Original comment by st...@regattacentral.com on 9 Dec 2013 at 7:04

GoogleCodeExporter commented 9 years ago
Alex,

I tried bulding 1.7.2 using git and maven (option #3 in your getting started). 
However, the build fails when I try 'mvn install'.  Here's the output....

Tests run: 563, Failures: 1, Errors: 0, Skipped: 0

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary:
[INFO]
[INFO] wro4j parent ...................................... SUCCESS [0.002s]
[INFO] wro4j core ........................................ FAILURE [15.506s]
[INFO] wro4j extensions .................................. SKIPPED
[INFO] wro4j maven plugin ................................ SKIPPED
[INFO] wro4j runner ...................................... SKIPPED
[INFO] Wro4j Examples .................................... SKIPPED
[INFO] wro4j demo ........................................ SKIPPED
[INFO] wro4j standalone example .......................... SKIPPED
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 15.766s
[INFO] Finished at: Mon Dec 09 14:19:08 EST 2013
[INFO] Final Memory: 5M/15M
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.
12.4:test (default-test) on project wro4j-core: There are test failures.
[ERROR]
[ERROR] Please refer to C:\Users\Steve\wro4j\wro4j-core\target\surefire-reports
for the individual test results.
[ERROR] -> [Help 1]
[ERROR]
[ERROR] To see the full stack trace of the errors, re-run Maven with the -e swit
ch.
[ERROR] Re-run Maven using the -X switch to enable full debug logging.
[ERROR]
[ERROR] For more information about the errors and possible solutions, please rea
d the following articles:
[ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureExc
eption
[ERROR]
[ERROR] After correcting the problems, you can resume the build with the command

[ERROR]   mvn <goals> -rf :wro4j-core
C:\Users\Steve\wro4j>

Any chance you can publish the latest jar's in the downloads section?

Many thanks,
Steve

Original comment by st...@regattacentral.com on 9 Dec 2013 at 7:22

GoogleCodeExporter commented 9 years ago
disregard that comment about building/getting 1.7.2!  I found the  link to the 
Google Drive folder with the binary's.  (just a heads-up that the 'Getting 
Started' page has only the link to the old downloads page)

Stay tuned.. I'll let you know how things go with the latest build.

Thanks again,
Steve

Original comment by st...@regattacentral.com on 9 Dec 2013 at 7:50

GoogleCodeExporter commented 9 years ago
Alex,

Everything seems to be working well with 1.7.2.   Please disregard issue 823

Thanks,
Steve

Original comment by st...@regattacentral.com on 9 Dec 2013 at 9:25

GoogleCodeExporter commented 9 years ago
The binaries are always available on maven central repo and google drive. It is 
never required to build it locally, unless you need the latest snapshot 
version. Closing the issue.

Original comment by alex.obj...@gmail.com on 9 Dec 2013 at 10:47