Open GoogleCodeExporter opened 9 years ago
Thanks,
I will add this in one of the future releases.
Original comment by alex.obj...@gmail.com
on 5 Aug 2014 at 3:12
Do you see it a replacement of current RubySassEngine implementation or it
should coexist with the old one?
Original comment by alex.obj...@gmail.com
on 5 Aug 2014 at 3:18
I would think it would be integrated with the existing RubySassEngine. The
changes don't affect any existing integration so users wont have any problems
when upgrading to a newer version.
However I am not familiar with this libraries configuration setup but if you
end up reworking how the load paths are set (possible XML config) it may end up
needing its own separate class.
Original comment by nstu...@earthadvantage.org
on 5 Aug 2014 at 3:39
I should also mention that at line 122 reads:
loadPath.replaceAll("'", "\\'").replaceAll("\\\\", "/")
That line should be looked at, I dont know Ruby very well and am not sure how
their path separators work but the replaceAll("\\\\", "/") has red flags all
over it. I couldnt seem to get the path to go into Ruby nicely but im sure
theres a proper way to do this. Definitely something to fix before you put it
in a release.
Original comment by nstu...@earthadvantage.org
on 5 Aug 2014 at 3:45
Original comment by alex.obj...@gmail.com
on 25 Sep 2014 at 8:25
Original issue reported on code.google.com by
nstu...@earthadvantage.org
on 2 Aug 2014 at 3:45Attachments: