equal sign needed on table comments

google-code-export / wwwsqldesigner

Automatically exported from code.google.com/p/wwwsqldesigner

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

equal sign needed on table comments #51

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

What steps will reproduce the problem?
1. Create table with comment
2. use mysql generate

What is the expected output? What do you see instead?
Comment has no "=" sign

Please provide any additional information below.
Look my patch to correct

Original issue reported on code.google.com by Metal3d on 22 Nov 2009 at 11:40

GoogleCodeExporter commented 9 years ago

Strange, my patch was not send, I re-send

Original comment by Metal3d on 22 Nov 2009 at 11:41

Attachments:

sqldesigner-comment-equal-sign.patch

GoogleCodeExporter commented 9 years ago

Hi,

according to http://dev.mysql.com/doc/refman/5.1/en/create-table.html, the 
equal sign
is not mandatory. Why do you require it?

Original comment by ondrej.zara on 23 Nov 2009 at 12:27

GoogleCodeExporter commented 9 years ago

Dont know why, but my mysql gave error without...

Original comment by Metal3d on 23 Nov 2009 at 12:32

GoogleCodeExporter commented 9 years ago

Commited in r64.

Original comment by ondrej.zara on 23 Nov 2009 at 1:07

Changed state: Fixed

GoogleCodeExporter commented 9 years ago

Nice. In fact... that was on my serveur which have MySQL 5.0.x, it seems that 
"=" is
not mandatory on 5.1.x

Adding "=" is not mandatory, but it permits to be more "compatible" :)

Happy to give patch again (I'm Patrice FERLET, I already gave you patches last 
year)

Original comment by Metal3d on 23 Nov 2009 at 2:21