search

google-code-export / zkcalendar

Automatically exported from code.google.com/p/zkcalendar
1 stars 1 forks source link

Unresponsive script warning #13

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Switching between month and week view, adding some events or moving from a
date interval to another, I start to receive the message I attached. There
seems to be some problem when the number of events get larger.
I tried both with ZKPE and ZKEE and the behaviour is the same.

Original issue reported on code.google.com by sim.vitt...@gmail.com on 2 Mar 2010 at 12:03

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by jumperc...@gmail.com on 2 Mar 2010 at 12:38

GoogleCodeExporter commented 9 years ago 
Hi, sim.vittori,
Could you post your sample code to reproduce this broblem

Original comment by jimmyshi...@gmail.com on 8 Mar 2010 at 1:57

GoogleCodeExporter commented 9 years ago 
Hi this is currently occurring on the live demo at http://zcal.zkoss.org

This is clearly a Daylight Saving Time issue: rendering the day that DST ends 
(in this case 28th March), or 
items on that day, puts the javascript into a infinite loop.

On the live site, either switch to Month View for March, or move the week view 
forward to the 28th.

Clearly this needs to be escalated as it is an absolute showstopper!

(This applies to version 2.0. In 1.0-RC there were a rendering errors for the 
start and end of DST that I could 
not track down - I was using UTC - which has no DST - for the Timezone for all 
my events, so it seems that 
there was something in the Calendar code that introduces a DST glitch.)

Original comment by david.ha...@jiffle.net on 18 Mar 2010 at 6:54

GoogleCodeExporter commented 9 years ago 
Correction: DST starts on the 28th March :)

Original comment by david.ha...@jiffle.net on 18 Mar 2010 at 6:57

GoogleCodeExporter commented 9 years ago 
Created a separate issue (#20) for the DST issue, in case it is not the same 
issue seen by Sim Vittori.

Original comment by david.ha...@jiffle.net on 18 Mar 2010 at 7:13

GoogleCodeExporter commented 9 years ago 
I have the same problem. My 100% reproducible case is as follows:
1. Go to zcal.zkoss.org
2. Wait until page is loaded
3. Switch to month view.
I checked zk 5 calendars demo (calendar 2.0 with zk 5.0.1 EE evaluation copy) 
locally
and case is reproduced. Processing banner will never hide and browser warn my 
about
infinite or slow script execution. Allowing to continue script execution doesn't
help. However, when I checked the latest zk 3 calendar demo 
distribution(calendar 1.0
with zk 3.6.3-3.6.4), it works without any problems. Seems to be a regression 
here.
Please advice. This is an urgent problem for me. I can't move to zk5 because of 
this
problem. I've attached the screenshot from my safari/ff3/ie browsers.

Original comment by barinov.sergei@gmail.com on 21 Mar 2010 at 9:05

Attachments:

GoogleCodeExporter commented 9 years ago 
Hi!
I have the same problem, please fix it or provide workaround. 
Thanks

Original comment by legebo...@gmail.com on 22 Mar 2010 at 6:32

GoogleCodeExporter commented 9 years ago 
You can download the jar that I fixed in svn
http://zkcalendar.googlecode.com/svn/trunk/zkcalendar/dist/lib/calendar.jar
and check this problem is solved

Original comment by jimmyshi...@gmail.com on 22 Mar 2010 at 6:52

GoogleCodeExporter commented 9 years ago 
Hi! 

I have the same problem, please fix it

Original comment by aducka...@gmail.com on 22 Mar 2010 at 7:17

GoogleCodeExporter commented 9 years ago 
Sorry, but I forgot to mention, that I used r34 version of calendar.jar to 
reproduce
the problem. The bug still exists! I've checked once more, loaded the latest
calendar.jar from repository, and the problem appears again. I tried to clean 
browser
and server cache, and this doesn't help.
Please fix this problem ASAP. I can't buy ZK5 EE license, because of this bug. 
Thanks

Original comment by barinov.sergei@gmail.com on 22 Mar 2010 at 9:05

GoogleCodeExporter commented 9 years ago 
Hi Barinov,

I retested R34 as part of Issue 20 (the issue that I created to handle this 
specific problem, since the hang is 
caused by the start of Daylight Saving Time) - 
http://code.google.com/p/zkcalendar/issues/detail?id=20

I found it to fix the issue in every situation except if you have an all-day 
event on the start of DST (in my case 
28th March). 

Note that I tested using an exploded demo war with calendar.jar, not r34 of 
demo.war (some of the zk 
libraries in dist of calendar seem to be incorrect - dropping zk5 release 
versions in instead fixed that).

Are you sure you restarted the servlet container and cleaned out any temporary 
working files?

Original comment by david.ha...@jiffle.net on 22 Mar 2010 at 10:09

GoogleCodeExporter commented 9 years ago 
Hi,
I did my testing with latest calendar.jar, downloaded using the following link:
http://zkcalendar.googlecode.com/svn/trunk/zkcalendar/dist/lib/calendar.jar
I did restart my tomcat, also I cleaned browser cache and tomcat work 
directory. I
didn't add any events. I just follow the steps, I described in comment #6, but 
on
localhost:
1. Unpack demo.war
2. Replace old calendar.jar with the latest from svn
3. Deploy demo directory under webapps folder.
3. Start servlet container(in my case it's tomcat)
4. Go to http://localhost:8080/demo/calendar.zul
5. After page is loaded switch to month view
6. Page loading hangs and browser alerts me about unresponsive script 
execution(like
on screenshots I provided)

I can provide you any other details per your request. This a show-stopper for 
me.

Original comment by barinov.sergei@gmail.com on 22 Mar 2010 at 11:13

GoogleCodeExporter commented 9 years ago 
Also I did replace demo libraries with latest zk EE 5.0.1 libraries. It doesn't 
help.
May be can you pack your war file and attach it here or update it in svn?
Sergei

Original comment by barinov.sergei@gmail.com on 22 Mar 2010 at 11:19

GoogleCodeExporter commented 9 years ago 
Hi, barinov
Could you tall me which time zone in your OS system,
I am try to reproduce your problem

Original comment by jimmyshi...@gmail.com on 22 Mar 2010 at 11:26

GoogleCodeExporter commented 9 years ago 
Hi,
My timezone is GMT+3(Moscow)

Original comment by barinov.sergei@gmail.com on 22 Mar 2010 at 1:57

GoogleCodeExporter commented 9 years ago 
Hi,
Any updates?

Original comment by barinov.sergei@gmail.com on 23 Mar 2010 at 9:16

GoogleCodeExporter commented 9 years ago 
The problem is 100% reproducible for me also in my evaluation. Please provide 
the fix asap. I cannot buy zk5 
license until the problem is fixed. Thx

Original comment by sergei.s...@gmail.com on 23 Mar 2010 at 7:03

GoogleCodeExporter commented 9 years ago 
Hi Sergei,

It would be helpful if you could isolate if the problem is related to rendering 
the calendar itself or the calendar 
data. What happens if you comment out the code from the demo that adds the 
events, leaving just a blank 
calendar?

Original comment by david.ha...@jiffle.net on 23 Mar 2010 at 7:39

GoogleCodeExporter commented 9 years ago 
Hi David,
When I commented out the model data, the calendar loaded without any hanging. 
So, the clean calendar doesn't 
have this bug. But when I put the events back, the problem reappears. So, what 
is a workaround? Can you fix it? 
I need to come to a decision regarding zk5.

Original comment by sergei.s...@gmail.com on 23 Mar 2010 at 7:58

GoogleCodeExporter commented 9 years ago 
Hi Sergei,

Good - I think that will help with getting a solution: It looks your problem is 
the same issue that I reported 
after retesting the updated Calendar in Issue 20 - that all-day events rendered 
on the day of the Start of DST 
crash month view. So it confirms that the modified calendar.jar has fixed most 
of the problem, only one issue 
remains. 

Daylight Saving Time issues are complex - hopefully Potix can fix it quickly, 
but personally I would rather have 
a fix that has been thought through than a quick hack. 

Thanks

Original comment by david.ha...@jiffle.net on 23 Mar 2010 at 8:52

GoogleCodeExporter commented 9 years ago 
Hi,
Any updates?
I tested calendar without any events, and agree with Sergei, that there is no 
problem
without events. So, when is the fix expected?
Thanks

Original comment by barinov.sergei@gmail.com on 25 Mar 2010 at 2:25

GoogleCodeExporter commented 9 years ago 
Sorry every one,
I have to work on other thing,
I will fix it on next week as soon as I can.

Original comment by jimmyshi...@gmail.com on 25 Mar 2010 at 4:57

GoogleCodeExporter commented 9 years ago 
FYI: Retested patched jar using default timezone of UTC. This seemed to make 
the problem worse, so I've added 
it as Issue 25

Original comment by david.ha...@jiffle.net on 26 Mar 2010 at 7:13

GoogleCodeExporter commented 9 years ago 
I have fixed DST problem.
http://zkcalendar.googlecode.com/svn/trunk/zkcalendar/dist/lib/calendar.jar
you can check it

Original comment by jimmyshi...@gmail.com on 11 Apr 2010 at 11:55

GoogleCodeExporter commented 9 years ago 
Confirm fixes DST issue. Can Sim Vittori confirm if it fixes his original issue?

Original comment by david.ha...@jiffle.net on 13 Apr 2010 at 12:45

GoogleCodeExporter commented 9 years ago 
Hi,
I checked the latest calendar.jar, and all works without hanging. So I confirm 
the
fix too.
Thanks a lot!

Original comment by barinov.sergei@gmail.com on 13 Apr 2010 at 12:49

GoogleCodeExporter commented 9 years ago 
Yes, it seems fixed for me as well.

Original comment by sim.vitt...@gmail.com on 13 Apr 2010 at 8:56

GoogleCodeExporter commented 9 years ago 
Fixed since Apr 13 2010

Original comment by jimmyshi...@gmail.com on 13 Apr 2010 at 10:19