google-code-export / zkcalendar

Automatically exported from code.google.com/p/zkcalendar
1 stars 1 forks source link

Start of DST hangs Calendar Demo #20

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Open http://zcal.zkoss.org/ in any browser
2. Either switch to Month View for March, or move the week view forward to the 
28th March (start of DST).

What is the expected output? What do you see instead?
Calendar hangs, often leaving the Processing message on screen. Eventually an 
'Unresponsive Script' dialog is displayed by the 
browser.
Continuing does not resolve the issue - the javascript is clearly in an 
infinite loop.

What version of the product are you using? On what operating system?
I believe the demo site is on ZKCalendar 2.0 and ZK 5.0

Please provide any additional information below.
This is clearly a Daylight Saving Time issue: rendering the day that DST ends 
(in this case 28th March), or 
items on that day, puts the javascript into a infinite loop.

Clearly this is a showstopper issue

Note that in 1.0-RC there were a rendering errors for the start and end of DST 
(when the rendering logic was in Java rather than 
JavaScript). I could find anything in my code to cause it - I was using UTC, 
which has no DST - for the Timezone for all my events, 
so it seems that there was something in the Calendar code that has a DST glitch.

Original issue reported on code.google.com by david.ha...@jiffle.net on 18 Mar 2010 at 7:11

GoogleCodeExporter commented 9 years ago
Follow up:
28th March is the start of DST in UK - it may be that the Javascript uses the 
DST information for the browser 
Locale?

Attached are two screenshots showing that all items for the page after DST 
start are rendered at the bottom of 
the page:

Original comment by david.ha...@jiffle.net on 19 Mar 2010 at 10:29

Attachments:

GoogleCodeExporter commented 9 years ago
Fixed since Mar 22 2010
You can download the jar file in svn 
http://zkcalendar.googlecode.com/svn/trunk/zkcalendar/dist/lib/calendar.jar

Original comment by jimmyshi...@gmail.com on 21 Mar 2010 at 4:43

GoogleCodeExporter commented 9 years ago
Hi Jimmy,

Thanks for the prompt response. I can confirm that the jar file fixes most of 
the problem: 

*Works:*
The calendar renders fine with no events on the day of DST Start
All-day events before, after and running across DST test out fine
Non-all day events on DST (both over hour of DST and after DST) test out fine.

*Outstanding Issue:*
Creating an all-day event on the day of DST Start renders wrongly in Week View 
and Hangs Month View:
In Week View it renders as a non-all day event, from 00:00 to 00:00 (see 
WeekView attachment)
In Month View it causes an unresponsive script and rendering issue (see 
MonthView attachment)

Original comment by david.ha...@jiffle.net on 21 Mar 2010 at 6:02

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by jimmyshi...@gmail.com on 22 Mar 2010 at 1:19

GoogleCodeExporter commented 9 years ago
FYI: Retested patched jar using default timezone of UTC. This seemed to make 
the problem worse, so I've added 
it as Issue 25

Original comment by david.ha...@jiffle.net on 26 Mar 2010 at 7:13

GoogleCodeExporter commented 9 years ago
I have fixed DST problem.
http://zkcalendar.googlecode.com/svn/trunk/zkcalendar/dist/lib/calendar.jar
you can check it

Original comment by jimmyshi...@gmail.com on 11 Apr 2010 at 11:56

GoogleCodeExporter commented 9 years ago
Confirmed fixed. Thank you.

Original comment by david.ha...@jiffle.net on 13 Apr 2010 at 12:43

GoogleCodeExporter commented 9 years ago
Fixed since Apr 13 2010

Original comment by jimmyshi...@gmail.com on 13 Apr 2010 at 12:49