google-deepmind / alphadev

Apache License 2.0
674 stars 67 forks source link

Bug on line 784 #3

Open fshabashev opened 1 year ago

fshabashev commented 1 year ago

Hi folks, I think you have a bug on line line. the function body is empty, it raises intendation error

def legal_actions(self) -> Sequence[Action]:
    ^
IndentationError: expected an indented block after function definition on line 784

https://github.com/deepmind/alphadev/blob/1a6eac1544c1075ef27814f09f9223cb84537c59/alphadev.py#L784

dovezp commented 1 year ago

"This repository contains relevant pseudocode and algorithms" there is more that is missing in some of the other methods that make me question why certain parts were withheld. How can we validate some of their metrics if we cannot reproduce with their provided samples?

iglesias commented 9 months ago

"This repository contains relevant pseudocode and algorithms" there is more that is missing in some of the other methods that make me question why certain parts were withheld. How can we validate some of their metrics if we cannot reproduce with their provided samples?

What are you specifically missing to validate the results?