google-deepmind / alphafold3

AlphaFold 3 inference pipeline.
Other
5.14k stars 578 forks source link

changed references to singularity .simg files to .sif files #14

Closed davidecarlson closed 1 week ago

davidecarlson commented 1 week ago

Per issue #12, this PR changes references in the installation instruction from singularity .simg files to the more current and standard .sif file format.

This should not have any other effect on the singularity image build process itself. I was able to successfully build the alphafold3.sif file.

google-cla[bot] commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

mlbileschi commented 1 week ago

Thank you! Interesting -- it looks like this is only a rename -- is the file extension load-bearing? As in does it serialize differently based on the file extension? Or is this cosmetic?

davidecarlson commented 1 week ago

I think that with relatively recent versions of singularity or apptainer (e.g., 3.0 and later), the difference should only be cosmetic because the .simg format isn't used at all.

mlbileschi commented 1 week ago

Thanks a bunch! merged in https://github.com/google-deepmind/alphafold3/commit/e07682c0643881390f59a7696fd91ad0232ea1ea