search

google-deepmind / alphafold3

AlphaFold 3 inference pipeline.
Other
5.07k stars 563 forks source link

zlib compatibility for libcifpp #40

Closed alchemistcai closed 1 week ago

alchemistcai commented 1 week ago

I failed to use docker to install alphafold3 in ubuntu2204 directly,so I use conda to do the cmds manually.

When I use pip install . --no-deps --verbose, cmake fails to find zlib for libcifpp.It Could NOT find ZLIB (missing: ZLIB_LIBRARY ZLIB_INCLUDE_DIR).

I use conda install zlib but it does not work.

Then I use apt to install:sudo apt install zlib1g zlib1g-dev and it works.

I add zlib1g,zlib1g-dev in dockerfile and the docker container also success.

google-cla[bot] commented 1 week ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Augustin-Zidek commented 1 week ago

Thanks for sending this PR.

I feel like this is too specific to your environment -- zlib will typically be present on most systems so I don't think we should be adding it in the Dockerfile.

Moreover, the error is quite informative.