google-deepmind / bsuite

bsuite is a collection of carefully-designed experiments that investigate core capabilities of a reinforcement learning (RL) agent
Apache License 2.0
1.51k stars 182 forks source link

setup.py broken after last commit #21

Closed MichelangeloConserva closed 4 years ago

MichelangeloConserva commented 4 years ago

Good morning,

You inserted an error in the setup.py file in your last commit. I report the error I receive below when executing the pip install command.

pip install \bsuite
    ERROR: Command errored out with exit status 1:
     command: 'C:\Users\Torquato\Anaconda3\envs\nlp\python.exe' -c 'import sys, setuptools, tokenize; sys.argv[0] = '"'"'C:\\Users\\Torquato\\Downloads\\bsuite\\setup.py'"'"'; __file__='"'"'C:\\Users\\Torquato\\Downloads\\bsuite\\setup.py'"'"';f=getattr(tokenize, '"'"'open'"'"', open)(__file__);code=f.read().replace('"'"'\r\n'"'"', '"'"'\n'"'"');f.close();exec(compile(code, __file__, '"'"'exec'"'"'))' egg_info
         cwd: C:\Users\Torquato\Downloads\bsuite\
    Complete output (1 lines):
    error in bsuite setup command: 'extras_require' must be a dictionary whose values are strings or lists of strings containing valid project/version requirement specifiers.
    ----------------------------------------
ERROR: Command errored out with exit status 1: python setup.py egg_info Check the logs for full command output.

I believe that the line that causes the problem is highlighted in the code below.

baselines_jax_require = [
    'dm-haiku',
    'dm-tree',
    'jax',
    'jaxlib',
    'git+git://github.com/deepmind/rlax.git'   <------------------
    'tqdm',
]

Pip is not able to recognise that command as a valid requirement specifier.

Thank you very much. Michelangelo Conserva

iosband commented 4 years ago

Thanks a lot for raising this - we will get this sorted ASAP

aslanides commented 4 years ago

Thanks for raising this! This should now be fixed by https://github.com/deepmind/bsuite/commit/66f8f70a784e9406e0fd2f565e992066fed0c243