google-deepmind / bsuite

bsuite is a collection of carefully-designed experiments that investigate core capabilities of a reinforcement learning (RL) agent
Apache License 2.0
1.51k stars 182 forks source link

Incompatible with Python 3.12 #52

Open pseudo-rnd-thoughts opened 5 months ago

pseudo-rnd-thoughts commented 5 months ago

BSuite uses imp which is deprecated in favour of importlib and removed in 3.12 https://docs.python.org/3.11/library/imp.html

bionicles commented 5 months ago

same issue today

bionicles commented 5 months ago
> rg 'imp\.'
setup.py
70:    version=imp.load_source('_metadata', 'bsuite/_metadata.py').__version__,

might be easy to fix, i only see one spot

workaround, you can clone the repo and edit setup.py

# import imp

from typing import Optional, Tuple
import os
import re

def extract(path: Optional[str] = None) -> str:
    assert path is not None
    assert os.path.exists(path)
    try:
        with open(path, "r") as f:
            content = f.read()
        return content
    except Exception as e:
        print("extract Exception", e)
        raise e

# imp.load_source('_metadata', 'bsuite/_metadata.py').__version__
def version_from_path(source_path: Optional[str] = None) -> Tuple[int, int, int]:
    assert source_path is not None
    assert source_path.endswith(".py")
    assert os.path.exists(source_path)
    content = extract(source_path)
    if match := re.search('\n__version__ = "(.*)"', content):
        version = match.group(1).lstrip("\n")
        major, minor, patch = map(int, version.split("."))
        return major, minor, patch
    raise ValueError("Failed to match a version")

METADATA_PATH = os.path.join("bsuite", "_metadata.py")
major, minor, patch = version_from_path(METADATA_PATH)
version = f"{major}.{minor}.{patch}"

this could be done a billion different ways but that's how I extract versions for "tree_plus"

later, in the call to setuptools.setup:

-     version=imp.load_source('_metadata', 'bsuite/_metadata.py').__version__,
+    version=version,

works on my machine :o