google-deepmind / concordia

A library for generative social simulation
Apache License 2.0
451 stars 82 forks source link

Calendar.ipynb example issues #66

Closed austinmw closed 1 week ago

austinmw commented 3 weeks ago

Hi, I have come across a few issues with the calendar.ipynb example that I thought I should report. I'm using commit 77d70f631779f11df150e4b6946dcbc51af48af4 (July 10, 2024).

1. Imports

The imports for the custom components are not set correctly with respect to the notebook's path. The examples directory is not in python's path by default, so these will fail to import:

from examples.phone.components import apps
from examples.phone.components import triggering

This is easy to fix, but figured I'd mention.

2. Hanging in notebook environment

I'm unable to run this notebook in a Jupyter environment to completion, however it does run to completion in script form. It gets through a few steps and then hangs. I suspect there may be a deadlock occurring in the code due to nested usage of ThreadPoolExecutor, but am not quite sure. (I'm currently running on a Macbook Pro and have tried it in basic Jupyter Lab and VSCode Notebooks — I've had a couple others reproduce this issue on their systems).

3. Never actually uses calendar app

Even after I convert to script and run to completion, it never actually uses the calendar app. I set break points at this line and this line, and it runs to the end of 12 episodes without ever hitting either of those. I've run this over a dozen times with gpt-4o to check, and I've also had another person reproduce and confirm this issue on their system.

When I step through with a debugger, it appears that this line never returns, and instead gets stuck in a recursive loop.