search

google-deepmind / concordia

A library for generative social simulation
Apache License 2.0
633 stars 148 forks source link

Fix issue with premise of buyer in haggling environment #81

Closed RisingOrange closed 1 month ago

RisingOrange commented 1 month ago

There is an mistake in the premise of the buyer in the haggling environment.

Currently it says: "Buyer is trying to buy some fruit from Seller. They are negotiating a price. Seller can sell the fruit for buyer_base_reward coins back in her home town."

It would make more sense if it would say this: "Buyer is trying to buy some fruit from Seller. They are negotiating a price. Buyer can sell the fruit for buyer_base_reward coins back in her home town."

The buyer intends to sell the fruit (which she bought from the seller) in her home town. This fits with the score of the buyer being the buyer_base_reward - the price they paid to buy the fruit: https://github.com/google-deepmind/concordia/blob/c35440e58c56554b8fa7351e500c62f043e8a1e0/concordia/contrib/components/game_master/bargain_payoffs.py#L186-L189

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.