mjcf module incorrectly requires all plugin elements to have a name attribute

google-deepmind / dm_control

Google DeepMind's software stack for physics-based simulation and Reinforcement Learning environments, using MuJoCo.

Apache License 2.0

3.75k stars 665 forks source link

mjcf module incorrectly requires all plugin elements to have a name attribute #450

Closed kgaranger closed 4 weeks ago

kgaranger commented 7 months ago

The various plugin elements have a name attribute defined in schema.xml of the mjcf module. However, some plugins like body plugins do not have a name in mujoco. Because dm_control automatically gives a name to plugin elements by default, generated MJCF files may result in an error when using them with mujoco.

nimrod-gileadi commented 4 weeks ago

I can't reproduce the issue of dm_control generating names for plugin elements. Maybe it was incidentally fixed by d4e76b3da3d23997ef008c78d9088e795427bb35, but you were using an older version?

Any way you're right that the name attribute shouldn't be there in the schema and I'll remove it. Sorry for missing this issue for so long.