google-deepmind / dm_robotics

Libraries, tools and tasks created and used at DeepMind Robotics.
Apache License 2.0
332 stars 32 forks source link

moma.utils.mujoco_rendering calls undefined method #11

Closed JeanElsner closed 1 year ago

JeanElsner commented 2 years ago

This line tries to call the update method of dm_control.viewer.gui.glfw_gui.GlfwWindow which doesn't exist. https://github.com/deepmind/dm_robotics/blob/48d5f0bfd76ad497faabd5823a25d89d4526b92e/py/moma/utils/mujoco_rendering.py#L146 The method would be easy to implement (a non-blocking function to render the given pixels similar to the event loop). Interestingly this is not caught by the unit test as that test uses a mock object for the viewer.

shacklestone commented 2 years ago

Looking into this.