search

google-deepmind / dqn

Lua/Torch implementation of DQN (Nature, 2015)
590 stars 160 forks source link

Error with Installation #7

Open ygrayson opened 4 years ago

ygrayson commented 4 years ago

When I was trying to install by running install_dependencies.sh, I encounter the following error:

Xitari installation completed
Installing Alewrap ... 
Cloning into 'alewrap'...

Missing dependencies for alewrap:
image 

Missing dependencies for image:
sys >= 1.0
xlua >= 1.0

Warning: unmatched variable LUALIB
-- The C compiler identification is GNU 7.4.0
-- The CXX compiler identification is GNU 7.4.0
-- Check for working C compiler: /usr/bin/cc
-- Check for working C compiler: /usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /usr/bin/c++
-- Check for working CXX compiler: /usr/bin/c++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
CMake Error at CMakeLists.txt:4 (FIND_PACKAGE):
  By not providing "FindTorch.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Torch", but
  CMake did not find one.

  Could not find a package configuration file provided by "Torch" with any of
  the following names:

    TorchConfig.cmake
    torch-config.cmake

  Add the installation prefix of "Torch" to CMAKE_PREFIX_PATH or set
  "Torch_DIR" to a directory containing one of the above files.  If "Torch"
  provides a separate development package or SDK, be sure it has been
  installed.

-- Configuring incomplete, errors occurred!
See also "/tmp/luarocks_sys-1.1-0-3574/sys/build/CMakeFiles/CMakeOutput.log".

Error: Failed installing dependency: https://raw.githubusercontent.com/torch/rocks/master/image-1.1.alpha-0.rockspec - Failed installing dependency: https://raw.githubusercontent.com/rocks-moonscript-org/moonrocks-mirror/master/sys-1.1-0.src.rock - Build error: Failed building.
Using https://raw.githubusercontent.com/torch/rocks/master/image-1.1.alpha-0.rockspec... switching to 'build' mode
Using https://raw.githubusercontent.com/rocks-moonscript-org/moonrocks-mirror/master/sys-1.1-0.src.rock... switching to 'build' mode
cmake -E make_directory build && cd build && cmake .. -DLUALIB= -DCMAKE_BUILD_TYPE=Release  -DCMAKE_INSTALL_PREFIX="/home/qianbo/Documents/dqn/torch/lib/luarocks/rocks/sys/1.1-0" && make
Error. Exiting.

It seems like while installing sys some configuration file couldn't be found. Any idea why installation didn't work?

Thanks in advance.

dninet commented 4 years ago

I am having the exact same problem. @ygrayson have you already solved it?

ygrayson commented 4 years ago

Nope. Currently I'm still having the same issue and it seems like much of the Torch has been moved to Pytorch, and the framework of this is a little outdated.

dninet commented 4 years ago

@ygrayson that's a bummer. Since this is something that I need for a thesis, I will post as soon as I find a way.

mgbellemare commented 4 years ago

Unless you really need the original DQN code, there are plenty of better re-implementations out there -- I can vouch that this one: https://github.com/google/dopamine comes close to the original code. In particular, we compared our hyperparameters with the ones here.

Cheers,

dninet commented 4 years ago

@mgbellemare thanks! I will check that out!