search

google-deepmind / ferminet

An implementation of the Fermionic Neural Network for ab-initio electronic structure calculations
Apache License 2.0
721 stars 120 forks source link

Remove deprecated kfac_jax kwarg #53

Closed gcassella closed 2 years ago

gcassella commented 2 years ago

The most recent commit to the kfac_jax repository removes the precedence keyword argument from kfac_jax.tag_graph_matcher.GraphPattern:

https://github.com/deepmind/kfac-jax/commit/b10c5a561ad580527d9bd28322722885535a491d

This results in a TypeError as we explicitly pass in this keyword argument in ferminet.curvature_tags_and_blocks. Easily fixed by removing the kwarg.

May also want to consider freezing the dependency on kfac_jax somehow to avoid breakages due to upstream changes in future?

jsspencer commented 2 years ago

Thanks. This was already fixed (at the same time as the kfac_jax refactor). Sorry, didn't realise that change was already public. HEAD should work now.