search

google-deepmind / ferminet

An implementation of the Fermionic Neural Network for ab-initio electronic structure calculations
Apache License 2.0
740 stars 129 forks source link

fix: the bug of `make_feature_layer` input #58

Closed wanghan-iapcm closed 1 year ago

wanghan-iapcm commented 1 year ago

the first input of the user customized make_feature_layer should be natoms rather than charges. This PR fix the bug.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

jsspencer commented 1 year ago

Please can you sign the CLA?